Skip to content

fix: error while loading iframe on mfe Unit Outline [FC-0062] #35828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisChV merged 4 commits into from
Nov 15, 2024
Merged

fix: error while loading iframe on mfe Unit Outline [FC-0062] #35828

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb25afa
fix: error while loading iframe on mfe Unit Outline
rpenido Nov 12, 2024
9dcd657
Merge branch 'master' into rpenido/fal-3941-fix-tag-error-mfe-unit-ou…
rpenido Nov 14, 2024
69ee026
docs: improve docstring
rpenido Nov 15, 2024
e7f9322
Merge branch 'master' into rpenido/fal-3941-fix-tag-error-mfe-unit-ou…
ChrisChV Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cms/static/js/views/pages/container_subviews.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,13 @@ function($, _, gettext, BaseView, ViewUtils, XBlockViewUtils, MoveXBlockUtils, H
},

renderTagElements: function(tags, depth, parentId) {
/* This function displays the tags in the sidebar of the legacy Unit Outline Page.
* It is not used when the Authoring MFE iframes a component in the Unit Outline. */
const parentElement = document.querySelector(`.content-tags-${parentId}`);
if (!parentElement) return;

const tagListElement = this;
tags.forEach(function(tag) {
const parentElement = document.querySelector(`.content-tags-${parentId}`);
var tagContentElement = document.createElement('div'),
tagValueElement = document.createElement('span');

Expand Down