fix: error while loading iframe on mfe Unit Outline [FC-0062] - #35828
Conversation
|
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Thanks @PKulkoRaccoonGang! |
|
@rpenido I'm not able to reproduce this issue anymore using latest |
pomegranited
left a comment
There was a problem hiding this comment.
👍 Ah yes thank you @rpenido , rebuilding the static assets let me reproduce this issue in master, and verify this fix.
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation -- left a nit re the added code comment.
-
User-facing strings are extracted for translationN/A
|
@rpenido Thanks! |
Co-authored-by: Jillian <jill@opencraft.com>
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
On the Course unit page after merging the PR with new iframe for xblocks, an issue with infinite loading of the iframe appeared if the unit/xblock has tags. This PR solves the problem with the error that appeared. Addition and processing of the tagging functionality is planned in future PRs.

Testing instructions
contentstore.new_studio_mfe.use_new_unit_pagetutor dev exec cms openedx-assets build --env=devto make sure the updated js is in place