Skip to content

Added a check to initialize legacy proctoring dashboard only if it's being used #35499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rijuma merged 2 commits into from
Sep 19, 2024
Merged

Added a check to initialize legacy proctoring dashboard only if it's being used #35499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c3f6e
fix: Adds a check to initialize legacy proctoring dashboard
rijuma Sep 18, 2024
166d94d
chore: Fixed a typo on a comment
rijuma Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lms/static/js/instructor_dashboard/instructor_dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ such that the value can be defined later than this assignment (file load order).

$activeSection = null;

var usesProctoringLegacyView = function () {

@schenedx schenedx Sep 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why name this function this way? Why not name the function usesProctoringMFEView and use the logic in a reverse way?

// If the element #proctoring-mfe-view is present, then uses the new MFE
// and the legacy views should not be initialized.
return !document.getElementById('proctoring-mfe-view');
}

SafeWaiter = (function() {
function safeWaiter() {
this.after_handlers = [];
Expand Down Expand Up @@ -200,7 +206,7 @@ such that the value can be defined later than this assignment (file load order).
}
];
// eslint-disable-next-line no-void
if (edx.instructor_dashboard.proctoring !== void 0) {
if (usesProctoringLegacyView() && edx.instructor_dashboard.proctoring !== void 0) {
sectionsToInitialize = sectionsToInitialize.concat([
{
constructor: edx.instructor_dashboard.proctoring.ProctoredExamAllowanceView,
Expand Down