Added a check to initialize legacy proctoring dashboard only if it's being used - #35499
Merged
Conversation
rijuma
force-pushed
the
rijuma/removing-old-special-exams-views
branch
from
September 19, 2024 13:49
bda035f to
18d6f6b
Compare
rijuma
force-pushed
the
rijuma/removing-old-special-exams-views
branch
from
September 19, 2024 13:49
18d6f6b to
61c3f6e
Compare
rijuma
changed the title
rijuma
marked this pull request as ready for review
September 19, 2024 14:08
zacharis278
approved these changes
Sep 19, 2024
schenedx
reviewed
Sep 19, 2024
|
|
||
| $activeSection = null; | ||
|
|
||
| var usesProctoringLegacyView = function () { |
Contributor
There was a problem hiding this comment.
Why name this function this way? Why not name the function usesProctoringMFEView and use the logic in a reverse way?
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new https://github.com/openedx/frontend-lib-special-exams should take care of the proctoring dashboard. The old views are still being loaded in the background. This can be seen since the old Backbone views extracted the
course_idfrom an elementstudent-proctored-exam-containerthat's not being rendered any more, this makes the old view takeundefinedas thecourse_idand some endpoints are being called with this value in them.When the new proctoring MFE is being used, a div with
id="proctoring-mfe-view"is rendered. I'm checking for its presence in the DOM to detect if it's being used, and if so, initialization on the legacy views is skipped.Useful information to include:
Testing instructions
undefinedin their path in the developer tools network tab (or returning404code whatsoever).Deadline