tsinghuax i18n changes - #353
Conversation
Extract strings for i18n Fix Javascript i18n Fix Email i18n Fix JS&Widgets i18n
There was a problem hiding this comment.
Do we want to internationalize these analytics.track calls? I don't think these show up for users, but are used for segmenting in our reports.
There was a problem hiding this comment.
My vote: no
@markchang will have to confirm but I believe that these are really used as 'keys'. Which is unfortunate as there's a mixed semantics here between key name and display name. Myself, I like to keep keys non-localizable. I'd be interested if theres a way to define a mapping between key name and a localizable display name.
But that's just my $0.02.
There was a problem hiding this comment.
I think this could be done more nicely with interpolate. Like this example:
var format = gettext('<strong>Will Release:</strong> %(date)s at %(time)s UTC');
var willReleaseAt = interpolate(format, {
'date': input_date,
'time': input_time
},
true);
There was a problem hiding this comment.
well, the risk here is that someone translates the actual '%(date)' - which is the keyname - which would break the later subsitution.
There was a problem hiding this comment.
Split up to avoid HTML in the internationalized string?
|
I think we should adhere to the style guidelines in our (unfortunately internal) wiki: |
|
@singingwolfboy I'm just not sure how we provide those comments to the translators. If there's an easy way (ie, a way we can be sure they will see), I'm all for it. I don't know if we can expect they will look at the actual source code. |
|
@cahrens Django actually has a facility for this built-in: https://docs.djangoproject.com/en/dev/topics/i18n/translation/#comments-for-translators I doubt we have it implemented for Mako templates or Javascript, though. |
There was a problem hiding this comment.
Any thoughts about how we should internationalize this? It's filled with jargon.
make the staff debug information appear in a show/hide span
Merge pull request openedx#337 from yokose-ks/develop/birch/restrict-persona…
Merge pull request openedx#337 from yokose-ks/develop/birch/restrict-persona… (cherry picked from commit 232702a) Conflicts: lms/djangoapps/instructor/views/instructor_dashboard.py lms/templates/instructor/instructor_dashboard_2/data_download.html
The text in the onboarding panel for submitted state is confusing. This PR updated the text so learners understood the wait
5 participants
Extract strings for i18n
Fix Javascript i18n
Fix Email i18n
Fix JS&Widgets i18n