Skip to content

Tsinghuax/lms i18n - #433

Merged
adampalay merged 3 commits into
masterfrom
tsinghuax/lms-i18n
Aug 1, 2013
Merged

Tsinghuax/lms i18n#433
adampalay merged 3 commits into
masterfrom
tsinghuax/lms-i18n

Conversation

@cpennington

@cpennington cpennington commented Jul 18, 2013

Copy link
Copy Markdown
Contributor

@sarina: Here's the i18n PR, and the i18n guidelines: https://edx-wiki.atlassian.net/wiki/display/ENG/I18n+coding+guidelines

@brianhw review also?

@sarina

sarina commented Jul 19, 2013

Copy link
Copy Markdown
Contributor

Lots of failing tests - try rebasing the branch and seeing if that fixes things.

sarina
sarina reviewed Jul 19, 2013
View reviewed changes
Comment thread lms/envs/common.py Outdated

@sarina sarina Jul 19, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edx-platform/conf/locale ?

@chrisndodge

chrisndodge commented Jul 19, 2013

Copy link
Copy Markdown
Contributor

Can I suggest this gets merged after next release candidate is made? I think we want to have enough time buffer to when this goes live.

sarina
sarina reviewed Jul 19, 2013
View reviewed changes
Comment thread lms/templates/footer.html Outdated

@sarina sarina Jul 19, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't translate EdX

nedbat
nedbat reviewed Jul 30, 2013
View reviewed changes
Comment thread lms/templates/register.html Outdated

@nedbat nedbat Jul 30, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't translate lorem ipsum. What text should really go here?

@adampalay adampalay Jul 30, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we kill the lorem? What's it even doing here?

@adampalay

adampalay commented Jul 31, 2013

Copy link
Copy Markdown
Contributor

Got the build to pass. I'm going to rebase my last few commit.

@adampalay

adampalay commented Jul 31, 2013

Copy link
Copy Markdown
Contributor

@cpennington @sarina , once the build passes?

@cpennington

cpennington commented Jul 31, 2013

Copy link
Copy Markdown
Contributor Author

👍

@sarina

sarina commented Jul 31, 2013

Copy link
Copy Markdown
Contributor

Ned left a few comments about indentation that it appears you haven't responded to - I'd ask him for his blessing as well. 👍 by me.

@adampalay

adampalay commented Jul 31, 2013

Copy link
Copy Markdown
Contributor

It's failing acceptance tests, need a moment

cpennington and others added 3 commits July 31, 2013 19:39
@cpennington @adampalay
LMS i18n from Tsinghua
0d3c449
@cpennington @adampalay
Remove news carousel and other unused pages
e8ee297 
Remove unused course_filter page

removes university_profile urls and templates

removes all university_profile views

remove news from templates/index
@adampalay
replace edx with variable substitution
69ffb6a 
fixes template errors

keep tos untranslated

formatting fixes
@adampalay

adampalay commented Jul 31, 2013

Copy link
Copy Markdown
Contributor

Ok, acceptance tests are passing. @nedbat , do I get the a-ok?

adampalay added a commit that referenced this pull request Aug 1, 2013
@adampalay
Merge pull request #433 from edx/tsinghuax/lms-i18n
933935a 
Tsinghuax/lms i18n
@adampalay
adampalay merged commit 933935a into master Aug 1, 2013
@adampalay
adampalay deleted the tsinghuax/lms-i18n branch August 1, 2013 14:00
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
@cpennington
Merge pull request openedx#433 from MITx/feature/kfiedler/courseware-…
b209d36 
…style

Made video go to the center of the screen in full screen
e-kolpakov referenced this pull request in open-craft/openedx-platform May 15, 2015
@ziafazal
Merge pull request #433 from edx-solutions/ekolpakov/dependency_updates
2c973a7 
Bumped XBlock version to include List/Dict string coercion
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
@stvstnfrd
Merge pull request openedx#433
d5149f1 
* stv/diff/imports:
  Unfork import statements
xavierchan pushed a commit to xavierchan/edx-platform-1 that referenced this pull request May 28, 2019
@gitfengri
Merge pull request openedx#433 from ufresh2013/trash
c789af1 
i版本升级bug
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Jan 19, 2021
@mariajgrimaldi
Merge pull request openedx#433 from eduNEXT/ju/ednx/JD-1
38257cf 
ju/ednx/JD-1: Microsite aware key-secret pairs for oauth
MoisesGSalas pushed a commit to eduNEXT/edx-platform that referenced this pull request Jan 12, 2022
Shimul Chowdhury Meysam Azad
fix: display right-to-left for rtl-languages in mobile (openedx#433)
c78a083 
(cherry picked from commit 6bf4364)

Co-authored-by: Meysam Azad <meysam@opencraft.com>
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Carla Duarte
fix: accurately represent pass/fail grade range (openedx#433)
36f567c
Danyal-Faheem pushed a commit to Danyal-Faheem/edx-platform that referenced this pull request Jul 15, 2025
@ahmed-arb
feat: add user preferred language report in admin dashboard (openedx#433
295e20e 
)

* feat: add user pref admin report

* chore: comment cleaning and standardizing admin reports name

* feat: add preferred language column in report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cpennington @sarina @chrisndodge @singingwolfboy @adampalay @nedbat @shnayder