Skip to content

fix: "Copy Unit" button should be behind enable_copy_paste_units flag - #33867

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:copy-unit-fix
Dec 1, 2023
Merged

fix: "Copy Unit" button should be behind enable_copy_paste_units flag#33867
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:copy-unit-fix

Conversation

@bradenmacdonald

Copy link
Copy Markdown
Contributor

Description

This is a quick follow-up and fix for #33724 . The new Copy Unit button was appearing regardless of the contentstore.enable_copy_paste_units waffle flag. And once a unit was copied, the other new functionality could become visible.

This fixes the button so that it only appears when the contentstore.enable_copy_paste_units feature flag is explicitly enabled.

Screenshot 2023-12-01 at 12 45 38 PM

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 1, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald
bradenmacdonald merged commit 99667f6 into openedx:master Dec 1, 2023
@bradenmacdonald
bradenmacdonald deleted the copy-unit-fix branch December 1, 2023 21:35
@openedx-webhooks

Copy link
Copy Markdown

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@open-craft-grove

Copy link
Copy Markdown

Sandbox destroy request received.

2 similar comments
@open-craft-grove

Copy link
Copy Markdown

Sandbox destroy request received.

@open-craft-grove

Copy link
Copy Markdown

Sandbox destroy request received.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants