[FC-0009] [FAL-3496] Copy/paste unit from within a unit - #33724

Merged

bradenmacdonald merged 8 commits into

openedx:masterfrom

open-craft:pooja/copy-paste-unit-to-unit

Dec 1, 2023

pkulkark commented Nov 15, 2023 •

edited by bradenmacdonald

Loading

Contributor

Description

This PR adds the option to copy/paste a unit from within a unit in CMS as per the designs in this wireframe. It also removes the last published section.

Supporting Information

openedx/modular-learning#96

OpenCraft Internal Jira task - FAL-3496

Screenshots

Copy button section:

Copy button hover/select:

Dropdown menu options when unit is copied:

Testing Instructions

Checkout the PR branch on the devstack.
Enable the contentstore.enable_copy_paste_units waffle flag in cms admin panel.
In Studio, open a unit and verify that the dropdown that shows up when New Unit button is clicked, only contains one option i.e. New Unit
Click on Copy to Clipboard button.
Verify that the dropdown now contains another option Paste as new unit.
Select Paste as new unit option and verify that the copies unit is pasted as a new unit.
Copy only a component from the unit to clipboard and verify that the paste option doesn't show up.

openedx-webhooks added the open-source-contribution label

openedx-webhooks commented Nov 15, 2023 •

edited

Loading

Thanks for the pull request, @pkulkark! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

bradenmacdonald changed the title ~~[WIP][FAL-3496] Copy/paste unit from within a unit~~ [WIP] Copy/paste unit from within a unit [FC-0009] [FAL-3496]

bradenmacdonald added the FC label

pkulkark force-pushed the pooja/copy-paste-unit-to-unit branch 3 times, most recently from 81db070 to 55cd961 Compare

November 20, 2023 16:40

pkulkark marked this pull request as ready for review

November 24, 2023 01:44

pkulkark changed the title ~~[WIP] Copy/paste unit from within a unit [FC-0009] [FAL-3496]~~ [FC-0009] [FAL-3496] Copy/paste unit from within a unit

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

pkulkark force-pushed the pooja/copy-paste-unit-to-unit branch from 506a0e5 to ce8ca40 Compare

November 24, 2023 01:49

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

17 similar comments

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deploy request received. Deployment will start soon.

open-craft-grove commented Nov 24, 2023

Sandbox deployment started.


          fix: small tweak to CSS to avoid button changing size

d18f98f

open-craft-grove commented Dec 1, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33724-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33724-139931.staging.do.opencraft.hosting

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5658124149-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5658124149-requirements.txt

yusuf-musleh approved these changes

View reviewed changes

yusuf-musleh left a comment

Member

👍 I did another review pass to test out the updated functionality, it's working well.

When a unit is in the clipboard, the dropdown menu button appears with the "Paste as new unit" option that pastes right away once clicked. If there is no unit in the clipboard, the dropdown arrow button is not shown.

open-craft-grove commented Dec 1, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33724-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33724-139931.staging.do.opencraft.hosting

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5658124149-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5658124149-requirements.txt

1 similar comment

open-craft-grove commented Dec 1, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33724-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33724-139931.staging.do.opencraft.hosting

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5658124149-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5658124149-requirements.txt

kaustavb12 commented Dec 1, 2023

Contributor

@bradenmacdonald @pkulkark

Can you please verify if the changes are reflecting now ?

bradenmacdonald commented Dec 1, 2023

Contributor

@kaustavb12 Yes, whatever you did has fixed it. Thanks!

bradenmacdonald commented Dec 1, 2023

Contributor

@jmakowski1123 @ali-hugo If you want to see the (final?) version, the sandbox has been updated: https://studio.pr-33724-139931.staging.do.opencraft.hosting/

bradenmacdonald approved these changes

View reviewed changes

bradenmacdonald merged commit f5b246d into openedx:master

bradenmacdonald deleted the pooja/copy-paste-unit-to-unit branch

December 1, 2023 19:33

openedx-webhooks commented Dec 1, 2023

@pkulkark 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bradenmacdonald pushed a commit to open-craft/openedx-platform that referenced this pull request


          feat: copy/paste unit from within a unit in Studio - feature flagged (o…

79f95d7

…penedx#33724)

(requires the contentstore.enable_copy_paste_units waffle flag)

bradenmacdonald mentioned this pull request

Backport to Quince: copy/paste unit from within a unit in Studio #33866

Merged

open-craft-grove commented Dec 1, 2023

Sandbox destroy request received.

3 similar comments

open-craft-grove commented Dec 1, 2023

Sandbox destroy request received.

open-craft-grove commented Dec 1, 2023

Sandbox destroy request received.

open-craft-grove commented Dec 1, 2023

Sandbox destroy request received.

edx-pipeline-bot commented Dec 1, 2023

Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

bradenmacdonald mentioned this pull request

fix: "Copy Unit" button should be behind enable_copy_paste_units flag #33867

Merged

edx-pipeline-bot commented Dec 1, 2023

Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment

edx-pipeline-bot commented Dec 1, 2023

Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

ali-hugo commented Dec 4, 2023

If you want to see the (final?) version, the sandbox has been updated: https://studio.pr-33724-139931.staging.do.opencraft.hosting/

@bradenmacdonald Thanks for the link, but I'm seeing the following error: "This site is currently being provisioned. Please try again in a few minutes."

kaustavb12 commented Dec 4, 2023

Contributor

Yes, whatever you did has fixed it. Thanks!

Thanks for the confirmation @bradenmacdonald . It was a known issue where the cached image keeps getting reused and needs to be manually deleted. We already have an internal ticket to fix this.

Thanks for the link, but I'm seeing the following error: "This site is currently being provisioned. Please try again in a few minutes."

@ali-hugo The automated sandbox was destroyed automatically since this PR was closed (on merge).

ali-hugo commented Dec 4, 2023

@kaustavb12 Oh, I see. Thanks for the explanation!

Now that the sandbox is no longer, is there somewhere else I can view this feature?

bradenmacdonald commented Dec 4, 2023

Contributor

@ali-hugo It will be available on the tagging/taxonomy sandbox, whenever we next update it. I think Jill will be updating it fairly soon.

bradenmacdonald commented Dec 4, 2023

Contributor

@ali-hugo Update: it's available now on the tagging/taxonomy sandbox :)

ali-hugo commented Dec 5, 2023

@bradenmacdonald Thanks! The UX feels much better now with those few small fixes. I'm interested to see what users think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC open-source-contribution