Skip to content

fix: name length validation #33615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnwesson merged 4 commits into from
Dec 4, 2023
Merged

fix: name length validation #33615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aabfc73
fix: name length validation
Inferato Oct 30, 2023
372a402
fix: name length validation
Inferato Oct 30, 2023
e62407d
test: test for length validation
Inferato Nov 14, 2023
2d63830
test: fix tests
Inferato Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openedx/core/djangoapps/user_api/accounts/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,10 @@ def get_name_validation_error(name):

"""
if name:
# Validation for the name length
if len(name) > 255:
return _("Full name can't be longer than 255 symbols")

regex = re.findall(r'https|http?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+', name)
return _('Enter a valid name') if bool(regex) else ''
else:
Expand Down
10 changes: 9 additions & 1 deletion openedx/core/djangoapps/user_api/accounts/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
from openedx.core.djangoapps.user_api.accounts import PRIVATE_VISIBILITY
from openedx.core.djangoapps.user_api.accounts.api import (
get_account_settings,
update_account_settings
update_account_settings,
get_name_validation_error
)
from openedx.core.djangoapps.user_api.accounts.tests.retirement_helpers import ( # pylint: disable=unused-import
RetirementTestCase,
Expand Down Expand Up @@ -570,6 +571,13 @@ def test_change_country_removes_state(self):
assert account_settings['country'] is None
assert account_settings['state'] is None

def test_get_name_validation_error_too_long(self):
"""
Test validation error when the name is too long.
"""
result = get_name_validation_error("A" * 256)
assert result == "Full name can't be longer than 255 symbols"


@patch('openedx.core.djangoapps.user_api.accounts.image_helpers._PROFILE_IMAGE_SIZES', [50, 10])
@patch.dict(
Expand Down