fix: name length validation - #33615
Conversation
|
Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi @openedx/2u-aperture! This is ready after the master is merged. |
|
@mphilbrick211: [inform] Moved to aurora from arch-bom on Contributions board. |
|
@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
[inform] This one also should have been Aperture. I will fix the ownership. Thank you for the contribution! |
According to the UserProfile limitation for the name field:
name = models.CharField(blank=True, max_length=255, db_index=True)
we need to add the validation for the name length.
A better solution would be to use the separate constant which we could use for both the model field and validation criteria, but considering that the field has been unchanged since Feb 2012 - it was rejected to simplify the fix.
Related: master