Skip to content

fix: name length validation - #33615

Merged
jsnwesson merged 4 commits into
openedx:open-release/quince.masterfrom
Inferato:lytvynenko/additional_name_check_quince
Dec 4, 2023
Merged

fix: name length validation#33615
jsnwesson merged 4 commits into
openedx:open-release/quince.masterfrom
Inferato:lytvynenko/additional_name_check_quince

Conversation

@Inferato

Copy link
Copy Markdown
Contributor

According to the UserProfile limitation for the name field:
name = models.CharField(blank=True, max_length=255, db_index=True)
we need to add the validation for the name length.
A better solution would be to use the separate constant which we could use for both the model field and validation criteria, but considering that the field has been unchanged since Feb 2012 - it was rejected to simplify the fix.

Related: master

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 30, 2023
@openedx-webhooks

openedx-webhooks commented Oct 30, 2023

Copy link
Copy Markdown

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Oct 30, 2023
@mphilbrick211
mphilbrick211 requested a review from a team October 30, 2023 16:51
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 30, 2023
@mphilbrick211

Copy link
Copy Markdown

Hi @openedx/2u-aperture! This is ready after the master is merged.

@robrap

robrap commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

@mphilbrick211: [inform] Moved to aurora from arch-bom on Contributions board.

@mphilbrick211
mphilbrick211 requested review from a team and removed request for a team December 4, 2023 15:12
@jsnwesson
jsnwesson merged commit 19844b9 into openedx:open-release/quince.master Dec 4, 2023
@openedx-webhooks

Copy link
Copy Markdown

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@robrap

robrap commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

[inform] This one also should have been Aperture. I will fix the ownership.

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants