Skip to content

Social link parsing approach changed #33499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Inferato wants to merge 2 commits into from
Closed

Social link parsing approach changed #33499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59bdecf
fix: Social link parsing approach changed
Inferato Oct 16, 2023
d6a9099
Merge branch 'master' into lytvynenko/changed_link_parsing
e0d Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions openedx/core/djangoapps/user_api/accounts/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,9 @@ def _get_username_from_social_link(platform_name, new_social_link):
if not new_social_link:
return new_social_link

# Parse the social link as if it were a URL.
parse_result = urlparse(new_social_link)
url_domain_and_path = parse_result[1] + parse_result[2]
url_stub = re.escape(settings.SOCIAL_PLATFORMS[platform_name]['url_stub'])
username_match = re.search(r'(www\.)?' + url_stub + r'(?P<username>.*?)[/]?$', url_domain_and_path, re.IGNORECASE)
username_match = re.search(r'(www\.)?' + url_stub + r'(?P<username>.+)(\?.*)?$', new_social_link, re.IGNORECASE)

if username_match:
username = username_match.group('username')
else:
Expand Down