Skip to content

Social link parsing approach changed - #33499

Closed
Inferato wants to merge 2 commits into
openedx:masterfrom
Inferato:lytvynenko/changed_link_parsing
Closed

Social link parsing approach changed#33499
Inferato wants to merge 2 commits into
openedx:masterfrom
Inferato:lytvynenko/changed_link_parsing

Conversation

@Inferato

Copy link
Copy Markdown
Contributor

Description

Since social URLs can be not only as a {social_media}/{username} we need to allow the use of any profile links

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2023
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@Inferato Inferato closed this Oct 23, 2023
@Inferato
Inferato deleted the lytvynenko/changed_link_parsing branch October 23, 2023 21:52
@openedx-webhooks

Copy link
Copy Markdown

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@Inferato
Inferato restored the lytvynenko/changed_link_parsing branch October 23, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants