Skip to content

fix: Get registration fields from site configuration - #33162

Merged
zainab-amir merged 1 commit into
openedx:open-release/palm.masterfrom
DmytroAlipov:get-registration-fields-from-site-config-palm
Sep 21, 2023
Merged

fix: Get registration fields from site configuration#33162
zainab-amir merged 1 commit into
openedx:open-release/palm.masterfrom
DmytroAlipov:get-registration-fields-from-site-config-palm

Conversation

@DmytroAlipov

@DmytroAlipov DmytroAlipov commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Description

This is a backport from the master branch

There is currently no way to control the REGISTRATION_EXTRA_FIELDS setting in Site Configuration.
screen_80

This fix adds the ability to control whether or not this field is displayed on the legacy registration page.

screen_81 screen_78

By default, data is taken from the settings.

Changes in the admin panel do not affect the behavior of this field in the Authn MFE:
screen_79

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2023
@DmytroAlipov

Copy link
Copy Markdown
Contributor Author

Something is broken in the pipelines. Can anyone help with this?

@mphilbrick211

mphilbrick211 commented Sep 5, 2023

Copy link
Copy Markdown

@e0d is this something you can help with?

Same question on #33165

@e0d

e0d commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Rerunning the check seems to have resolved it.

@DmytroAlipov

Copy link
Copy Markdown
Contributor Author

@mphilbrick211 @e0d Thanks 😊

@mphilbrick211

mphilbrick211 commented Sep 6, 2023

Copy link
Copy Markdown

Hi @openedx/vanguards! Would someone be able to please review and merge for us after the master is merged? Thank you!

@zainab-amir
zainab-amir merged commit 5c53971 into openedx:open-release/palm.master Sep 21, 2023
@openedx-webhooks

Copy link
Copy Markdown

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov
DmytroAlipov deleted the get-registration-fields-from-site-config-palm branch September 21, 2023 08:37
shURenZHOUluxun pushed a commit to EduTrigger/edx-platform that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants