Skip to content

fix: get registration fields from site configuration (master) - #33165

Merged
zainab-amir merged 3 commits into
openedx:masterfrom
DmytroAlipov:get-registration-fields-from-site-config
Sep 21, 2023
Merged

fix: get registration fields from site configuration (master)#33165
zainab-amir merged 3 commits into
openedx:masterfrom
DmytroAlipov:get-registration-fields-from-site-config

Conversation

@DmytroAlipov

Copy link
Copy Markdown
Contributor

Description

There is currently no way to control the REGISTRATION_EXTRA_FIELDS setting in Site Configuration.
screen_80

This fix adds the ability to control whether or not this field is displayed on the legacy registration page.

screen_81 screen_78

By default, data is taken from the settings.

Changes in the admin panel do not affect the behavior of this field in the Authn MFE:
screen_79

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2023
@DmytroAlipov

Copy link
Copy Markdown
Contributor Author

Something is broken in the pipelines. Can anyone help with this?

@DmytroAlipov DmytroAlipov changed the title fix: get registration fields from site configuration fix: get registration fields from site configuration (master) Sep 4, 2023
@e0d

e0d commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

@mphilbrick211

Copy link
Copy Markdown

Hi @openedx/vanguards! Would someone be able to please review/merge for us?

There is also a backport: #33162

@zainab-amir

Copy link
Copy Markdown
Contributor

We have created a ticket in our backlog to review this change.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 6, 2023
@zainab-amir
zainab-amir merged commit f81b64f into openedx:master Sep 21, 2023
@openedx-webhooks

Copy link
Copy Markdown

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

irtazaakram pushed a commit that referenced this pull request Sep 25, 2023
Co-authored-by: Edward Zarecor <ezarecor@tcril.org>
Co-authored-by: Zainab Amir <zainab.amir@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants