fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent by DmytroAlipov · Pull Request #32684 · openedx/openedx-platform

DmytroAlipov · 2023-07-07T15:32:51Z

Description

[Instructor Dashboard > Membership] Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent

Steps to Reproduce:

Go to the Instructor Dashboard > Membership
Leave input field for Batch Enrollment empty
Click on [Enroll] button

Another bug found:

if you add invalid users to Batch Enrollment:

if you add invalid users to Batch Beta Tester Addition:

Now everything works correctly:

openedx-webhooks · 2023-07-07T15:32:58Z

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

mphilbrick211 · 2023-08-07T12:53:42Z

hi @DmytroAlipov! Is this ready for review?

DmytroAlipov · 2023-08-07T13:22:41Z

@mphilbrick211 yes ;)

mphilbrick211 · 2023-08-07T18:08:36Z

Hi @openedx/fed-bom! Is this something you could help review/merge for us? Thanks!

abdullahwaheed · 2023-08-08T07:28:41Z

sure @mphilbrick211 we'll review it

abdullahwaheed · 2023-09-06T12:50:56Z

Suggested change

renderList(gettext('This field must not be blank'), [])

renderList(gettext('This field must not be blank'), []);

@abdullahwaheed done

abdullahwaheed · 2023-09-06T12:51:03Z

Suggested change

gettext('Users must create and activate their account before they can be promoted to beta tester.')

gettext('Users must create and activate their account before they can be promoted to beta tester.');

@abdullahwaheed I disagree, this gettext is inside unshift

Perhaps you meant ; on the next line

abdullahwaheed · 2023-09-06T12:51:42Z

Suggested change

invalidIdentifier.length === 0 &&

errors.length === 0 &&

enrolled.length === 0 &&

allowed.length === 0 &&

autoenrolled.length === 0 &&

notenrolled.length === 0 &&

notunenrolled.length === 0

invalidIdentifier.length === 0

&& errors.length === 0

&& enrolled.length === 0

&& allowed.length === 0

&& autoenrolled.length === 0

&& notenrolled.length === 0

&& notunenrolled.length === 0

@abdullahwaheed done

abdullahwaheed · 2023-09-06T12:51:50Z

Suggested change

renderList(gettext('This field must not be blank'), [])

renderList(gettext('This field must not be blank'), []);

@abdullahwaheed done

DmytroAlipov · 2023-09-06T18:15:47Z

I don't understand why the CMS test failed. The backed part is not affected at all in this PR.

DmytroAlipov · 2023-09-06T18:25:19Z

In the Palm branch, everything was successful for the same PR

mphilbrick211 · 2023-10-04T13:04:33Z

Hi @abdullahwaheed! Are you able to merge this for us?

mphilbrick211 · 2023-10-24T21:07:05Z

Hi @abdullahwaheed! Are you able to merge this for us?

Hi @abdullahwaheed - friendly follow-up on this :)

mphilbrick211 · 2024-03-19T23:36:17Z

Hi @abdullahwaheed! Are you able to merge this for us?

Hi @abdullahwaheed - friendly follow-up on this :)

Hi @abdullahwaheed and @openedx/2u-fed-bom! Would someone able to please merge this for us?

openedx-webhooks · 2024-03-21T09:24:33Z

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-pipeline-bot · 2024-03-21T10:43:01Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2024-03-21T13:11:24Z

2U Release Notice: This PR has been deployed to the edX production environment.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 7, 2023

DmytroAlipov mentioned this pull request Jul 7, 2023

fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent for Palm #32688

Closed

DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-master branch 2 times, most recently from 9dc8985 to 36115db Compare July 13, 2023 05:57

DmytroAlipov changed the title ~~fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent~~ WIP: fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent Jul 18, 2023

DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-master branch from 36115db to a168884 Compare July 18, 2023 11:02

DmytroAlipov changed the title ~~WIP: fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent~~ fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent Jul 18, 2023

abdullahwaheed self-requested a review August 8, 2023 07:28

mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 23, 2023

abdullahwaheed suggested changes Sep 6, 2023

View reviewed changes

DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-master branch from a168884 to 71034b8 Compare September 6, 2023 17:40

mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 6, 2023

mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 18, 2023

abdullahwaheed approved these changes Oct 4, 2023

View reviewed changes

DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-master branch 2 times, most recently from 890bbed to e78a1c7 Compare October 4, 2023 09:36

fix: validation error for empty Batch Enrollment/Beta Tester

35f0844

DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-master branch from e78a1c7 to 35f0844 Compare October 4, 2023 10:13

Merge branch 'master' into fix-error-for-empty-list-enrollment-master

2449ea7

mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 16, 2023

abdullahwaheed approved these changes Mar 21, 2024

View reviewed changes

abdullahwaheed merged commit 79f6223 into openedx:master Mar 21, 2024

DmytroAlipov deleted the fix-error-for-empty-list-enrollment-master branch March 21, 2024 09:38

DmytroAlipov mentioned this pull request Mar 21, 2024

fix: validation error for empty Batch Enrollment/Beta Tester to Quince #34404

Merged

	renderList(gettext('This field must not be blank'), [])
	renderList(gettext('This field must not be blank'), []);

	gettext('Users must create and activate their account before they can be promoted to beta tester.')
	gettext('Users must create and activate their account before they can be promoted to beta tester.');

-                invalidIdentifier.length === 0 &&
-                errors.length === 0 &&
-                enrolled.length === 0 &&
-                allowed.length === 0 &&
-                autoenrolled.length === 0 &&
-                notenrolled.length === 0 &&
-                notunenrolled.length === 0
+                invalidIdentifier.length === 0
+                && errors.length === 0
+                && enrolled.length === 0
+                && allowed.length === 0
+                && autoenrolled.length === 0
+                && notenrolled.length === 0
+                && notunenrolled.length === 0

Uh oh!

Conversation

DmytroAlipov commented Jul 7, 2023

Description

Now everything works correctly:

Uh oh!

openedx-webhooks commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mphilbrick211 commented Aug 7, 2023

Uh oh!

DmytroAlipov commented Aug 7, 2023

Uh oh!

mphilbrick211 commented Aug 7, 2023

Uh oh!

abdullahwaheed commented Aug 8, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DmytroAlipov commented Sep 6, 2023

Uh oh!

DmytroAlipov commented Sep 6, 2023

Uh oh!

mphilbrick211 commented Oct 4, 2023

Uh oh!

mphilbrick211 commented Oct 24, 2023

Uh oh!

mphilbrick211 commented Mar 19, 2024

Uh oh!

openedx-webhooks commented Mar 21, 2024

Uh oh!

edx-pipeline-bot commented Mar 21, 2024

Uh oh!

edx-pipeline-bot commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openedx-webhooks commented Jul 7, 2023 •

edited

Loading