Skip to content

fix: validation error for empty Batch Enrollment/Beta Tester to Quince - #34404

Merged
abdullahwaheed merged 1 commit into
openedx:open-release/quince.masterfrom
DmytroAlipov:fix-error-for-empty-list-enrollment-quince
Apr 5, 2024
Merged

fix: validation error for empty Batch Enrollment/Beta Tester to Quince#34404
abdullahwaheed merged 1 commit into
openedx:open-release/quince.masterfrom
DmytroAlipov:fix-error-for-empty-list-enrollment-quince

Conversation

@DmytroAlipov

Copy link
Copy Markdown
Contributor

This is a backport from the master.

Description

[Instructor Dashboard > Membership] Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent

Steps to Reproduce:

  1. Go to the Instructor Dashboard > Membership
  2. Leave input field for Batch Enrollment empty
  3. Click on [Enroll] button

screen_14

screen_15

Another bug found:

  • if you add invalid users to Batch Enrollment:
screen_12
  • if you add invalid users to Batch Beta Tester Addition:
screen_13

Now everything works correctly:

screen_16 screen_17

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2024
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 21, 2024
@mphilbrick211

Copy link
Copy Markdown

Hi @openedx/2u-fed-bom! Would someone be able to merge this for us? You recently merged the master.

@abdullahwaheed
abdullahwaheed merged commit eb11261 into openedx:open-release/quince.master Apr 5, 2024
@openedx-webhooks

Copy link
Copy Markdown

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov
DmytroAlipov deleted the fix-error-for-empty-list-enrollment-quince branch April 5, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants