fix: support files with a unicode signature in the Instructor Dashboard API - #32116
Merged
Agrendalath merged 1 commit intoMay 4, 2023
Merged
Conversation
…rd API Without this, files with BOM (byte order mark; generated e.g., by Microsoft Excel) cannot be read properly.
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @Agrendalath! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
farhaanbukhsh
approved these changes
Apr 29, 2023
farhaanbukhsh
left a comment
farhaanbukhsh
left a comment
Member
There was a problem hiding this comment.
👍
- ✅ I tested on the master devstack and I could reproduce the issue and test the fix.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this, files with BOM (byte order mark; generated e.g., by Microsoft Excel) cannot be read properly.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
from .common import FEATURES; FEATURES['ALLOW_AUTOMATED_SIGNUPS'] = Trueto yourlms/envs/private.py.Deadline
"None"
Author's notes
To verify that the downloaded file contains BOM, you can inspect it with the
filecommand. You can also view it withcat -A(GNU coreutils),cat -vet(Mac OS) orbat -A.Other information
Private-ref: BB-7349