fix(nutmeg): support files with a unicode signature in the Instructor Dashboard API - #534
Merged
Agrendalath merged 1 commit intoMay 4, 2023
Conversation
…rd API Without this, files with BOM (byte order mark; generated e.g., by Microsoft Excel) cannot be read properly.
Agrendalath
changed the title
farhaanbukhsh
approved these changes
Apr 29, 2023
farhaanbukhsh
left a comment
farhaanbukhsh
left a comment
Member
There was a problem hiding this comment.
👍
- ✅ I tested the fix on devstack on nutmeg and master
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports openedx#32116 to the common Nutmeg branch.