feat: allow using all components of LibraryContentBlock - #31788
Merged
pkulkark merged 1 commit intoFeb 22, 2023
Merged
Conversation
Setting max_count to a negative value resulted in raising an unhandled ValueError. Currently, it selects all children of the LibraryContentBlock.
|
Thanks for the pull request, @Agrendalath! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
pkulkark
approved these changes
Feb 20, 2023
pkulkark
left a comment
Contributor
There was a problem hiding this comment.
@Agrendalath LGTM 👍
- I tested this: Verified the RCB shows all the components from library when count is set to -1 as described in testing instructions.
- I read through the code
|
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting max_count to a negative value resulted in raising an unhandled
ValueError. With this change, it selects all children of the LibraryContentBlock.Testing instructions
library_contentto theAdvanced Module Listin a course.{x}should be the number of available components in the library).Deadline
"None"
Other information
Private-ref: BB-7062.