feat[nutmeg]: allow using all components of LibraryContentBlock [BB-7062] - #519
Merged
pkulkark merged 1 commit intoFeb 20, 2023
Conversation
Setting max_count to a negative value resulted in raising an unhandled ValueError. Currently, it selects all children of the LibraryContentBlock.
pkulkark
approved these changes
Feb 20, 2023
pkulkark
left a comment
pkulkark
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
- I tested this: verified the behaviour in parent PR
- I read through the code
pkulkark
deleted the
agrendalath/bb-7062_use_all_questions_in_rcb_nutmeg_backport
branch
February 20, 2023 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports openedx#31788 to Nutmeg.
Setting max_count to a negative value resulted in raising an unhandled ValueError. Currently, it selects all children of the LibraryContentBlock.