fix https://github.com/edx/edx-platform/pull/2566 - #2791
fix https://github.com/edx/edx-platform/pull/2566#2791fmyzjs wants to merge 1 commit into
Conversation
|
@nedbat and @fmyzjs, just commented in the original thread - https://github.com/edx/edx-platform/pull/2566#issuecomment-36550609 |
|
@talbs if i change to be $homepage-bg-image :url('…') ; something wrong when i rake it.. if nothing to be done ,css cannot exec something look like homepage-bg-image :'../…/.jpg' |
|
@talbs you can test it by using Stanford-Online/edx-theme ,homepage-bg-image cannot be found without this commit |
|
I think it would be a better idea to rename the variable to But yeah, I had the same issue with IONISx/edx-theme@c1c181c. |
|
@tusbar if you changed the var in your custome-theme,the theme will not work ,look like : failed: [localhost] => (item=lms) => {"changed": true, "cmd": "SERVICE_VARIANT=lms rake lms:gather_assets:aws ", "delta": "0:00:08.545348", "end": "2014-03-04 19:14:54.607203", "item": "lms", "rc": 1, "start": "2014-03-04 19:14:46.061855"} FATAL: all hosts have already failed -- aborting |
|
@tusbar and @fmyzjs, thanks for the info. I think @tusbar's suggestion (below) of renaming the Sass variable. That seems to address all of the rendering cases we have on the table, including:
How does that sound? If its agreeable, then I'm happy to review it as part of this pull request or in another. |
|
Thank you.I got it |
|
@fmyzjs Have you signed a contributor's agreement? http://code.edx.org/individual-contributor-agreement.pdf |
|
@fmyzjs We haven't heard from you, and it sounds like this pull request needs more work before it can be merged. We'd love to get this fix into the project, but we can't if you don't respond to our comments. Unless you get back to this soon and address some of this comments, we're going to have to close this pull request. |
…onditions if necessary Related to openedx#2788 openedx#2791
…onditions if necessary Related to openedx#2788 openedx#2791
Fork edx-platform to allow usage of ecommerce service and Paybox:
- ecommerce code is not compatible with Cypress regarding the JWT authentification, so we use new dependency edx_rest_api_client (added to fun-apps requirements) to auth
- Display prices in Euro currency
- Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
- Change edX payement related wording for our own
Related to issues openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712 openedx#2705 openedx#1831 openedx#2788 openedx#2791 openedx#2863
Fork edx-platform to allow usage of ecommerce service and Paybox:
- ecommerce code is not compatible with Cypress regarding the JWT authentification, so we use new dependency edx_rest_api_client (added to fun-apps requirements) to auth
- Display prices in Euro currency
- Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
- Change edX payement related wording for our own
Related to issues openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712 openedx#2705 openedx#1831 openedx#2788 openedx#2791 openedx#2863
Dogwood openedx#3116
5 participants
fix https://github.com/edx/edx-platform/pull/2566