Skip to content

Refactor changed lang test - #2636

Closed
wedaly wants to merge 1 commit into
masterfrom
will/refactor-changed-lang-test
Closed

Refactor changed lang test#2636
wedaly wants to merge 1 commit into
masterfrom
will/refactor-changed-lang-test

Conversation

@wedaly

@wedaly wedaly commented Feb 18, 2014

Copy link
Copy Markdown
Contributor
  • Move DOM interactions for checking the language out of the test and into the dashboard page object.
  • Use a stronger assertion for checking that the language changed (not just that we were able to find the title)
  • Log out instead of deleting cookies.
  • Moved language tests into a separate module.

@flowerhack

@wedaly

wedaly commented Feb 20, 2014

Copy link
Copy Markdown
Contributor Author

Tests are failing on this branch for reasons I don't totally understand -- it seems that with too many courses available, the "Find courses" page doesn't update immediately. I was able to get the page to update by waiting (a long time, over 1 minute) and logging in / out. I suspect there's some caching nonsense at work, but I don't have time to investigate further.

Closing the PR, but hopes it serves as a useful reference for when we re-enable the change lang tests.

@wedaly wedaly closed this Feb 20, 2014
@wedaly
wedaly deleted the will/refactor-changed-lang-test branch February 20, 2014 21:30
rmoch added a commit to openfun/edx-platform that referenced this pull request Mar 3, 2016
…ourse is also free. Closes openedx#2635

Display course price in euro. Related to openedx#2636
rmoch added a commit to openfun/edx-platform that referenced this pull request Mar 4, 2016
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 8, 2016
…ourse is also free. Closes openedx#2635

Display course price in euro. Related to openedx#2636
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 8, 2016
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 10, 2016
…ourse is also free. Closes openedx#2635

Display course price in euro. Related to openedx#2636
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 10, 2016
rmoch added a commit to openfun/edx-platform that referenced this pull request Mar 16, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, then we use new dependancy edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own
     Related to openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712
rmoch added a commit to openfun/edx-platform that referenced this pull request Mar 17, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, then we use new dependancy edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own
     Related to openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712

Quick fix missing i18n in javascript

This closes issue openedx#2705.
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 22, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, then we use new dependancy edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own
     Related to openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712

Quick fix missing i18n in javascript

This closes issue openedx#2705.
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 23, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, then we use new dependancy edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own
     Related to openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712

Quick fix missing i18n in javascript

This closes issue openedx#2705.
regisb pushed a commit to openfun/edx-platform that referenced this pull request Mar 24, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, then we use new dependancy edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own
     Related to openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712

Quick fix missing i18n in javascript

This closes issues openedx#2705 and openedx#1831.
regisb pushed a commit to openfun/edx-platform that referenced this pull request May 9, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, then we use new dependancy edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own
     Related to openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712

Quick fix missing i18n in javascript

This closes issues openedx#2705 and openedx#1831.
regisb pushed a commit to openfun/edx-platform that referenced this pull request May 26, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, so we use new dependency edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own

Related to issues openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712 openedx#2705 openedx#1831 openedx#2788 openedx#2791 openedx#2863
rmoch added a commit to openfun/edx-platform that referenced this pull request Aug 26, 2016
Fork edx-platform to allow usage of ecommerce service and Paybox:
     - ecommerce code is not compatible with Cypress regarding the JWT authentification, so we use new dependency edx_rest_api_client (added to fun-apps requirements) to auth
     - Display prices in Euro currency
     - Alphabeticaly order Paybox fields to ensure they are posted in the same order they were signed where created
     - Change edX payement related wording for our own

Related to issues openedx#1831 openedx#2637 openedx#2636 openedx#2635 openedx#2656 openedx#2644 openedx#2662 openedx#2712 openedx#2705 openedx#1831 openedx#2788 openedx#2791 openedx#2863
Dogwood openedx#3116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant