[SE-4888] Cherry-pick Fix use a registration field order when using a registration extension - #419
Conversation
|
|
||
| custom_form = get_registration_extension_form() | ||
| if custom_form: | ||
| custom_form_field_names = [field_name for field_name, field in custom_form.fields.items()] |
There was a problem hiding this comment.
I think we could have done something like this here
custom_form_field_names = list(custom_form.fields.keys())
what do you think?
There was a problem hiding this comment.
I agree, this could be simplified, though it is already merged on edX master and possibly I wouldn't make an unnecessary code drift.
you probably need @gabor-boros 😄 |
@tinumide Give me some monies and I'll update the description 😊 |
So sorry to bother you |
would you mind 2 BTCs? |
I meant minutes, but my autocorrect won. Sorry 😅 🤦 |
tinuademargaret
left a comment
There was a problem hiding this comment.
👍
- I tested this PR according to the test instructions and confirmed that it functions well
- I read through the code
-
I checked for accessibility issuesNA -
Includes documentationNA
|
|
||
| custom_form = get_registration_extension_form() | ||
| if custom_form: | ||
| custom_form_field_names = [field_name for field_name, field in custom_form.fields.items()] |
|
@gabor-boros thanks for the good work 👍.. This is good to go |
|
Thank you @tinumide for the quick review! |
This PR cherry-picks https://github.com/edx/edx-platform/pull/26633
Test instructions