New course creator group. - #266
Merged
Merged
Conversation
ghost
assigned
Contributor
There was a problem hiding this comment.
Hmm. I think we are missing some permission assertions. If this function can be called from a webapp, the interactive user (aka Mark) needs to be authenticated and authorized to add/remove people from the COURSE_CREATOR_GROUP_NAME.
I wonder if we need to assert that caller.is_staff = True here (as well as on the corresponding 'add' method)
Contributor
|
+1 besides that one comment. Also need rebase. |
added 5 commits
June 26, 2013 10:48
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Cpennington/fix tests
Kelketek
referenced
this pull request
in open-craft/openedx-platform
Oct 21, 2014
slashes: formatted ids removed
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Jan 18, 2019
Let user register before enroll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put this in behind a feature flag so it will have no impact initially (as the creator group is empty).
Also added some test coverage for lines I touched while refactoring.