Skip to content

[BTR-39] Upgrade django-user-tasks and edx-enterprise - #25745

Closed
0x29a wants to merge 2 commits into
openedx:open-release/koa.masterfrom
open-craft:0x29a/upgrade_packages_with_squashed_warnings
Closed

[BTR-39] Upgrade django-user-tasks and edx-enterprise#25745
0x29a wants to merge 2 commits into
openedx:open-release/koa.masterfrom
open-craft:0x29a/upgrade_packages_with_squashed_warnings

Conversation

@0x29a

@0x29a 0x29a commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

In this PR I upgraded django-user-tasks to version 1.3.1 and edx-enterprise to version 3.13.0. These versions squash many warnings.

For django-user-tasks:

  1. I found the oldest version that includes commit from Squash DRF deprecation warnings django-user-tasks#97
  2. make compile-requirements COMPILE_OPTS="--upgrade-package django-user-tasks==1.3.1".

For edx-enterprise:

  1. I found the oldest version that includes commit from Sof/squash warnings edx-enterprise#1052
  2. Updated constraint.
  3. make compile-requirements COMPILE_OPTS="--upgrade-package edx-enterprise==3.13.0".

To include squash from staff-graded-xblock (openedx/staff-graded-xblock#29), we need to release a new version of this package.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @0x29a! I've created OSPR-5278 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 2, 2020
@0x29a 0x29a closed this Dec 3, 2020
@0x29a
0x29a deleted the 0x29a/upgrade_packages_with_squashed_warnings branch December 3, 2020 16:27
@openedx-webhooks

Copy link
Copy Markdown

@0x29a Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@natabene natabene removed open-source-contribution PR author is not from Axim or 2U rejected labels Dec 7, 2020
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants