Squash DRF deprecation warnings - #97
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 359 359
Branches 47 47
=========================================
Hits 359 359 Continue to review full report at Codecov.
|
UsamaSadiq
approved these changes
Nov 21, 2020
mraarif
approved these changes
Nov 21, 2020
This was referenced Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite had been reporting 3 deprecation warnings (which were preventing a Django REST Framework upgrade) and a ResourceWarning:
The DRF deprecation warnings were also appearing in the edx-platform test suite, since it uses this package. This should pave the way to upgrading DRF in edx-platform to at least 3.11, since these were the last deprecation warnings reporting breakage that would occur with that version.
Implementation notes:
from django.conf import settings, sincetest_settings.pyitself isn't in an importable location.