Skip to content

ARCHBOM-1584: remove internal references to edx_django_utils from tests - #25504

Merged
robrap merged 1 commit into
masterfrom
robrap/ARCHBOM-1584-fix-monitoring-references
Nov 2, 2020
Merged

ARCHBOM-1584: remove internal references to edx_django_utils from tests#25504
robrap merged 1 commit into
masterfrom
robrap/ARCHBOM-1584-fix-monitoring-references

Conversation

@robrap

@robrap robrap commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

Tests were referring to internal implementation
details of edx-django-utils. This comment removes
those references to free the library up to be
refactored.

ARCHBOM-1584

Tests were referring to internal implementation
details of edx-django-utils. This comment removes
those references to free the library up to be
refactored.

ARCHBOM-1584
@robrap

robrap commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

FYI: @regisb:

  1. One less WaffleSwitchNamespace usage for you to be concerned with. :)
  2. I updated a test for the Toggle State Endpoint, and hopefully it won't be lost in the transition to edx-toggles.

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@robrap robrap changed the title ARCHBOM-1584: remove internal references to edx_django_utils ARCHBOM-1584: remove internal references to edx_django_utils from tests Nov 2, 2020
@robrap

robrap commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

FYI: Because this is just test code, and I am on call, I am going to merge.

@robrap
robrap merged commit acd8459 into master Nov 2, 2020
@robrap
robrap deleted the robrap/ARCHBOM-1584-fix-monitoring-references branch November 2, 2020 23:12
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants