ARCHBOM-1584: refactor monitoring app - #70
Merged
Conversation
robrap
commented
Oct 30, 2020
idegtiarov
suggested changes
Oct 30, 2020
Contributor
Author
|
Thanks for your thoughts, @idegtiarov. I'll look into whatever is reasonably quick.
|
robrap
commented
Oct 30, 2020
robrap
left a comment
Contributor
Author
There was a problem hiding this comment.
@idegtiarov: I did what made sense on this PR, and tried to add explanations.
I still have code coverage I need to add to land this PR.
|
@robrap Thanks for the answers and clarifications. |
* Add ADR to explain new app organization. * Apply new app organization to the monitoring Django app. * Remove middleware ordering checks. This is not a typical Django feature and it is painful when refactoring. * Add CachedCustomMonitoringMiddleware, CodeOwnerMonitoringMiddleware, and MonitoringMemoryMiddleware to the public API. * Deprecate above middleware from old location. * Deprecate methods from modules that were always meant to be used from the public API: * accumulate * increment * set_custom_attribute * set_custom_attributes_for_course_key * Add additional custom attributes for deprecated classes and methods to make them safer to retire. ARCHBOM-1584
robrap
force-pushed
the
robrap/ARCHBOM-1584-add-monitoring-internal
branch
from
November 2, 2020 23:17
6da1a97 to
241bb42
Compare
Contributor
Author
|
@feanil: FYI: I plan on merging, but I wanted to let you know I added these tests for an existing middleware to increase coverage: https://github.com/edx/edx-django-utils/blob/241bb42ae5f511c25ab095018d05966cd509c63d/edx_django_utils/monitoring/tests/test_middleware.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Note: Some additional details in the CHANGELOG.rst change in the PR.
JIRA:
ARCHBOM-1584
Testing instructions:
Merge checklist:
Post merge:
finished.