ARCHBOM-1584: use unreleased edx-django-utils branch - #25491
Closed
robrap wants to merge 4 commits into
Closed
Conversation
Tests should not import private variables from other libraries. This was breaking on a refactor of thee library.
|
Your PR has finished running tests. There were no failures. |
Contributor
Author
|
Closing this PR. It has proven that the edx-django-utils update should be ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing edx-django-utils PR: openedx/edx-django-utils#70
Note: It turns out that a commit on this branch may need to be merged before the refactor can land, because a test was using a private variable.