AA-393: Update Next Section Logic - #25485
Conversation
| # Exclude deprecated fields | ||
| exclude = ('dashboard_tracking_code',) | ||
|
|
There was a problem hiding this comment.
Realized I forgot this during earlier clean-up
mikix
left a comment
mikix
left a comment
There was a problem hiding this comment.
I think this makes sense to me.
2adbd45 to
cb3c990
Compare
There was a problem hiding this comment.
Now that we log out the more descriptive message, I felt like I could remove this. Maybe I should use a prefix though so they are easy to find. Let me update.
There was a problem hiding this comment.
Removed this and switched to return None, None because now that we check all schedules within a certain time period, this scenario is going to happen very often and logging it out would be unhelpful.
There was a problem hiding this comment.
We manually calculate due dates in our function anyway so these weren't doing anything
335feb4 to
a8eadb5
Compare
ciduarte
left a comment
ciduarte
left a comment
There was a problem hiding this comment.
Thanks for adding in those doc strings!
Inside content_highlights.py, we had code to calculate due dates for when there isn't graded content, but we could only reach that code path if the user had an assignment with a due date at the target date. Now we will check for all learners who could be in range of having an update and let the code in content_highlights.py decide if a highlight should be sent
a8eadb5 to
6b16fcd
Compare
| ItemFactory.create(parent=self.course, category='chapter', highlights=['good stuff 1']) | ||
| ItemFactory.create(parent=self.course, category='chapter', highlights=['good stuff 2']) | ||
| ItemFactory.create(parent=self.course, category='chapter', highlights=['good stuff 3']) | ||
| ItemFactory.create(parent=self.course, category='chapter', highlights=['good stuff 4']) |
There was a problem hiding this comment.
So I added in this fourth one because the course duration has the default value of 28 days. So by having 4 sections, the offsets will be evenly divided instead of possibly having something like 9 days and 8 hours (which is what it was when there were only three)
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
5 participants
Inside content_highlights.py, we had code to calculate due dates
for when there isn't graded content, but we could only reach that
code path if the user had an assignment with a due date at the
target date. Now we will check for all learners who could be in
range of having an update and let the code in content_highlights.py
decide if a highlight should be sent