Skip to content

makes peer grading error message more user-friendly (ORA-304) #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adampalay wants to merge 1 commit into from
Closed

makes peer grading error message more user-friendly (ORA-304) #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion common/lib/xmodule/xmodule/peer_grading_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,15 @@ def peer_grading(self, _data=None):
problem_list_dict = problem_list_json
success = problem_list_dict['success']
if 'error' in problem_list_dict:
error_text = problem_list_dict['error']
# A bit of a hack: `error_text` is meant to be set
# to `problem_list_dict['error']`. We're overwriting that
# here with something less scary-looking.
# Once we fix it on the ora side, we can reset this to
# `problem_list_dict['error']`
error_text = (

@waheedahmed waheedahmed Feb 13, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the place where we have to overwrite error message because the error message mentioned in screenshot https://edx-wiki.atlassian.net/browse/ORA-304 is created here: https://github.com/edx/edx-ora/blob/master/peer_grading/calibration.py#L180 on ORA side called from is_student_caliberated at this point: https://github.com/edx/edx-ora/blob/master/peer_grading/views.py#L221.

We should overwrite this error message here: https://github.com/edx/edx-platform/blob/master/common/lib/xmodule/xmodule/peer_grading_module.py#L404

"Have you made any submissions for that problem? "
"If you haven't, please try making one."
)

problem_list = problem_list_dict['problem_list']

Expand Down