makes peer grading error message more user-friendly (ORA-304) - #2542
Closed
adampalay wants to merge 1 commit into
Closed
makes peer grading error message more user-friendly (ORA-304)#2542adampalay wants to merge 1 commit into
adampalay wants to merge 1 commit into
Conversation
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
This is not the place where we have to overwrite error message because the error message mentioned in screenshot https://edx-wiki.atlassian.net/browse/ORA-304 is created here: https://github.com/edx/edx-ora/blob/master/peer_grading/calibration.py#L180 on ORA side called from is_student_caliberated at this point: https://github.com/edx/edx-ora/blob/master/peer_grading/views.py#L221.
We should overwrite this error message here: https://github.com/edx/edx-platform/blob/master/common/lib/xmodule/xmodule/peer_grading_module.py#L404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@symbolist
@waheedahmed