Skip to content

AA-405: UI fixes for courseware - #25413

Merged
ciduarte merged 1 commit into
masterfrom
ciduarte/AA-405
Oct 23, 2020
Merged

AA-405: UI fixes for courseware#25413
ciduarte merged 1 commit into
masterfrom
ciduarte/AA-405

Conversation

@ciduarte

@ciduarte ciduarte commented Oct 22, 2020 •
edited
Loading

Copy link
Copy Markdown
  • Tooltip removed from "Shift due dates" button
  • Removed sentence casing from "Shift due dates" and "Show answer" button
  • Removed icons from "Show answer", "Save", "Reset", and "Hint" buttons (hardcoded these buttons to show for the screenshot, unclear if this is a typical use case)

AA-405_buttons

  • Improved responsiveness of shift dates banner

AA-405_shift_dates_banner_on_mobile

ciduarte
ciduarte commented Oct 22, 2020
View reviewed changes
Comment thread common/lib/xmodule/xmodule/css/capa/display.scss Outdated

@ciduarte ciduarte Oct 22, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of this name but it was already being used and I didn't want to mess with it

ciduarte
ciduarte commented Oct 22, 2020
View reviewed changes
Comment thread lms/templates/problem.html Outdated
Comment on lines 29 to 53

@ciduarte ciduarte Oct 22, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big copy and paste from the section below, but I removed the icon from each button

mikix
mikix approved these changes Oct 23, 2020
View reviewed changes

@mikix mikix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

Comment thread lms/static/sass/course/layout/_banner_cta.scss
flex: none;
margin-top: $baseline;

@media only screen and (min-width: 630px) {

@mikix mikix Oct 23, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a variable for that somewhere? I totally believe we don't, just a bummer.

@ciduarte ciduarte Oct 23, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah when I did a quick search for @media only screen, all the values were hardcoded :/

@edx-status-bot

edx-status-bot commented Oct 23, 2020

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@ciduarte
ciduarte merged commit 3e2fc5d into master Oct 23, 2020
@ciduarte
ciduarte deleted the ciduarte/AA-405 branch October 23, 2020 14:15
@edx-pipeline-bot

edx-pipeline-bot commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been rolled back from the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mikix mikix mikix approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ciduarte @edx-status-bot @edx-pipeline-bot @mikix