Skip to content

On marketing site, disable course settings options that do not work. - #210

Merged
cahrens merged 13 commits into
masterfrom
christina/course-settings-drupal
Jun 20, 2013
Merged

On marketing site, disable course settings options that do not work.#210
cahrens merged 13 commits into
masterfrom
christina/course-settings-drupal

Conversation

@cahrens

@cahrens cahrens commented Jun 19, 2013

Copy link
Copy Markdown

When on the marketing site (edx.org) disable portions of the course settings page in Studio that do not actually work in that environment.

When on the marketing site (edx.org) disable portions of the course settings page in Studio that do not actually work in that environment.
@cahrens

cahrens commented Jun 19, 2013

Copy link
Copy Markdown
Author

To see what this will look like on the marketing site, put this in the CMS dev.py file:
MITX_FEATURES['ENABLE_MKTG_SITE'] = True
MKTG_URLS = { '': 'https://www.edx.org'}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on all the localizations

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wondered if you remembered to localize your trash can tooltip for the assets page. I'm sure you did. :)

@talbs

talbs commented Jun 19, 2013

Copy link
Copy Markdown
Contributor

@cahrens, some styling has been added to these conditional "notices" and I've corrected the copy issues you noted.

@frrrances, would you mind peeking at my Sass rules/styling here? I've tried to build in a new UI element (notices) we can use elsewhere and plumbed through an in-context example. This also adds a new extend called "well" that we should sync up with some of the "initial state" view work you did for PDF textbooks (placing a grey/inset instructional content area).

Thanks much!

@talbs

talbs commented Jun 20, 2013

Copy link
Copy Markdown
Contributor

Just added a few changes:

  • I wrapped the course promoting URL/email your students about the promoting URL (the impetus for this was seeing that the promoting URL was "http://none" when our mtking settings were added to cms/envs/dev.py). Since there wasn't a URL to share, I figured just hide it.
  • quick tweaks to the font-sizes, added a subtle hover effect, and removed icons that just created noise.

@cahrens can you confirm that removing the promoting URL is the right thing to do when there is no URL to promote?

@cahrens

cahrens commented Jun 20, 2013

Copy link
Copy Markdown
Author

@talbs No, we do not want to hide the URL. You are seeing "None" because my instructions for modifying dev.py aren't quite correct. Should be--
MKTG_URLS = { 'ROOT': 'https://www.edx.org'}

On edx prod site, the root will be properly set an will not sure as None (as it does today if you try out the course settings page there).

Of course, there is a minor issue that the URL that is shown is not exactly right, but it will be set up to redirect to the correct place.

@talbs

talbs commented Jun 20, 2013

Copy link
Copy Markdown
Contributor

@cahrens thanks for the feedback. The conditionals have now been removed around the course URL info. Things should be good from my end. Thanks for the help and patience in going back and forth.

@cahrens

cahrens commented Jun 20, 2013

Copy link
Copy Markdown
Author

@chrisndodge and @frrrances Please review.

I just submitted a change to fix the unit test, so the next time this branch runs, it should pass tests. Also ran the CMS integration tests on my machine.

@chrisndodge

Copy link
Copy Markdown
Contributor

+1 once the build/test completes. Hopefully this feature will be short lived as we deprecate the XML filesystem. Also, TBD, is whether Studio (and MongoDB) becomes the authority for courseware marketing (e.g. Drupal calls an API to get this). However that's a wider discussion between Marketing and Eng.

@frrrances

Copy link
Copy Markdown
Contributor

👍

@chrisndodge

Copy link
Copy Markdown
Contributor

Tests passed, seems like we can merge

cahrens pushed a commit that referenced this pull request Jun 20, 2013
On marketing site, disable course settings options that do not work.
@cahrens
cahrens merged commit 1a5b58a into master Jun 20, 2013
@cahrens
cahrens deleted the christina/course-settings-drupal branch June 20, 2013 16:15
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
Added the course image to the about page, even if the video doesn't exis...
e-kolpakov referenced this pull request in open-craft/openedx-platform Sep 12, 2014
…-redux

mattdrayer/api-proficiency-redux: New StudentGradebook
ataki pushed a commit to ataki/edx-platform that referenced this pull request Mar 26, 2015
prabhanshu pushed a commit to prabhanshu/edx-platform that referenced this pull request Oct 13, 2018
* Revert "WIP (openedx#188)"

This reverts commit 6c27bcd.

* Revert "OAuth Restricted Application APIs (openedx#174)"

This reverts commit b65bdea.
edx-secure pushed a commit that referenced this pull request Dec 10, 2020
Incident Management security fixes 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants