On marketing site, disable course settings options that do not work. - #210
Conversation
When on the marketing site (edx.org) disable portions of the course settings page in Studio that do not actually work in that environment.
|
To see what this will look like on the marketing site, put this in the CMS dev.py file: |
There was a problem hiding this comment.
+1 on all the localizations
There was a problem hiding this comment.
Yeah, I wondered if you remembered to localize your trash can tooltip for the assets page. I'm sure you did. :)
|
@cahrens, some styling has been added to these conditional "notices" and I've corrected the copy issues you noted. @frrrances, would you mind peeking at my Sass rules/styling here? I've tried to build in a new UI element (notices) we can use elsewhere and plumbed through an in-context example. This also adds a new extend called "well" that we should sync up with some of the "initial state" view work you did for PDF textbooks (placing a grey/inset instructional content area). Thanks much! |
|
Just added a few changes:
@cahrens can you confirm that removing the promoting URL is the right thing to do when there is no URL to promote? |
|
@talbs No, we do not want to hide the URL. You are seeing "None" because my instructions for modifying dev.py aren't quite correct. Should be-- On edx prod site, the root will be properly set an will not sure as None (as it does today if you try out the course settings page there). Of course, there is a minor issue that the URL that is shown is not exactly right, but it will be set up to redirect to the correct place. |
|
@cahrens thanks for the feedback. The conditionals have now been removed around the course URL info. Things should be good from my end. Thanks for the help and patience in going back and forth. |
|
@chrisndodge and @frrrances Please review. I just submitted a change to fix the unit test, so the next time this branch runs, it should pass tests. Also ran the CMS integration tests on my machine. |
|
+1 once the build/test completes. Hopefully this feature will be short lived as we deprecate the XML filesystem. Also, TBD, is whether Studio (and MongoDB) becomes the authority for courseware marketing (e.g. Drupal calls an API to get this). However that's a wider discussion between Marketing and Eng. |
|
👍 |
|
Tests passed, seems like we can merge |
On marketing site, disable course settings options that do not work.
Added the course image to the about page, even if the video doesn't exis...
…-redux mattdrayer/api-proficiency-redux: New StudentGradebook
Add shib support for suclass
* Revert "WIP (openedx#188)" This reverts commit 6c27bcd. * Revert "OAuth Restricted Application APIs (openedx#174)" This reverts commit b65bdea.
Incident Management security fixes 2
When on the marketing site (edx.org) disable portions of the course settings page in Studio that do not actually work in that environment.