SE-1496 (backport) Add flag to enable password change form in admin - #210
Merged
samuelallan72 merged 1 commit intoFeb 26, 2020
Merged
Conversation
This was previously disabled because changing another user's password is both not usually recommended and bypasses password policy. Here, we add a feature flag (`ENABLE_CHANGE_USER_PASSWORD_ADMIN`) to allow re-enabling this password change form. This allows continued use of this functionality by clients that require it. (cherry picked from commit 39de23c)
|
👍
|
shimulch
pushed a commit
that referenced
this pull request
Dec 10, 2020
Incident Management security fixes 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously disabled because changing another user's password is
both not usually recommended and bypasses password policy. Here, we add
a feature flag (
ENABLE_CHANGE_USER_PASSWORD_ADMIN) to allowre-enabling this password change form. This allows continued use of this
functionality by clients that require it.
(cherry picked from commit 39de23c)
See upstream PR https://github.com/edx/edx-platform/pull/21616 for test instructions. This is identical apart from being based on our ironwood branch instead of master.
Reviewer: