Skip to content

SE-1496 (backport) Add flag to enable password change form in admin - #210

Merged
samuelallan72 merged 1 commit into
opencraft-release/ironwood.2from
samuel/port-gate-change-password
Feb 26, 2020
Merged

SE-1496 (backport) Add flag to enable password change form in admin#210
samuelallan72 merged 1 commit into
opencraft-release/ironwood.2from
samuel/port-gate-change-password

Conversation

@samuelallan72

@samuelallan72 samuelallan72 commented Feb 24, 2020

Copy link
Copy Markdown
Member

This was previously disabled because changing another user's password is
both not usually recommended and bypasses password policy. Here, we add
a feature flag (ENABLE_CHANGE_USER_PASSWORD_ADMIN) to allow
re-enabling this password change form. This allows continued use of this
functionality by clients that require it.

(cherry picked from commit 39de23c)


See upstream PR https://github.com/edx/edx-platform/pull/21616 for test instructions. This is identical apart from being based on our ironwood branch instead of master.

Reviewer:

This was previously disabled because changing another user's password is
both not usually recommended and bypasses password policy. Here, we add
a feature flag (`ENABLE_CHANGE_USER_PASSWORD_ADMIN`) to allow
re-enabling this password change form. This allows continued use of this
functionality by clients that require it.

(cherry picked from commit 39de23c)
@samuelallan72 samuelallan72 self-assigned this Feb 25, 2020
@clemente

Copy link
Copy Markdown

👍

  • I tested this: (describe what you tested)
    • On LMS and CMS, I didn't see the link nor the password page.
    • After enabling the feature in /edx/etc/lms.yml and /edx/etc/studio.yml in lms.env.json and cms.env.json, I could see the link to change the password, and I could change it, both from LMS and CMS.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@samuelallan72
samuelallan72 merged commit 9b02bd0 into opencraft-release/ironwood.2 Feb 26, 2020
@samuelallan72
samuelallan72 deleted the samuel/port-gate-change-password branch February 26, 2020 22:24
shimulch pushed a commit that referenced this pull request Dec 10, 2020
Incident Management security fixes 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants