Skip to content

Revert "Merge pull request #16447 from appsembler/omar/hide-library-b… - #16524

Merged
efischer19 merged 1 commit into
masterfrom
efischer/revert_library
Nov 9, 2017
Merged

Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…#16524
efischer19 merged 1 commit into
masterfrom
efischer/revert_library

Conversation

@efischer19

Copy link
Copy Markdown
Contributor

…utton"

This reverts commit 9a9ef19, reversing
changes made to f61cbe7.

JIRA link for context

Un-revert plan going forward

FYI @fredsmith @nasthagiri @OmarIthawi

…utton"

This reverts commit 9a9ef19, reversing
changes made to f61cbe7.
@efischer19

Copy link
Copy Markdown
Contributor Author

jenkins run bokchoy

@efischer19

Copy link
Copy Markdown
Contributor Author

@awaisdar001 awaisdar001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You have failing bokchoy?

@efischer19
efischer19 merged commit 801a948 into master Nov 9, 2017
efischer19 pushed a commit that referenced this pull request Nov 9, 2017
Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…
@efischer19
efischer19 deleted the efischer/revert_library branch November 9, 2017 20:11
@efischer19

Copy link
Copy Markdown
Contributor Author

The bokchoy failure is probably a flaky test that has nothing to do with this code. I merged in order to keep the hotfix on-track to go out before EOD; there's also a second bokchoy run going here: https://build.testeng.edx.org/job/edx-platform-bok-choy-pr/45580/

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, November 14, 2017.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants