Skip to content

Hide the create library for non-staff users when DISABLE_COURSE_CREATION - #16447

Merged
nasthagiri merged 1 commit into
openedx:masterfrom
appsembler:omar/hide-library-button
Nov 6, 2017
Merged

Hide the create library for non-staff users when DISABLE_COURSE_CREATION#16447
nasthagiri merged 1 commit into
openedx:masterfrom
appsembler:omar/hide-library-button

Conversation

@OmarIthawi

@OmarIthawi OmarIthawi commented Nov 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

This is a tiny bug that has been reported a while ago:

Is there a setting similar to 'DISABLE_COURSE_CREATION': True

That I can add to my CMS settings or cms/envs/common.py, to disable the library creation for non staff in cypress? I can't find it in the docs.

Thanks!

@OmarIthawi OmarIthawi closed this Nov 3, 2017
@openedx-webhooks

openedx-webhooks commented Nov 3, 2017

Copy link
Copy Markdown

Thanks for the pull request, @OmarIthawi! I've created OSPR-1995 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Nov 3, 2017
@OmarIthawi OmarIthawi reopened this Nov 4, 2017
@OmarIthawi
OmarIthawi changed the base branch from open-release/ginkgo.master to master November 4, 2017 08:05
@OmarIthawi
OmarIthawi force-pushed the omar/hide-library-button branch from 16d4d5e to e94878a Compare November 4, 2017 08:06
@OmarIthawi
OmarIthawi force-pushed the omar/hide-library-button branch from e94878a to cb5e76e Compare November 4, 2017 08:07
@OmarIthawi OmarIthawi changed the title (WIP) Hide the create library for non-staff users when DISABLE_COURSE_CREATION Hide the create library for non-staff users when DISABLE_COURSE_CREATION Nov 4, 2017
@OmarIthawi

OmarIthawi commented Nov 4, 2017

Copy link
Copy Markdown
Member Author

@antoviaque since you were interested in that bug.

@nedbat

nedbat commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

@edx/educator-devs this seems easy enough?

@nasthagiri
nasthagiri merged commit 9a9ef19 into openedx:master Nov 6, 2017
@openedx-webhooks

openedx-webhooks commented Nov 6, 2017

Copy link
Copy Markdown

@OmarIthawi 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi

OmarIthawi commented Nov 7, 2017

Copy link
Copy Markdown
Member Author

@nedbat @nasthagiri Thank you! That's a 5 star PR triage 😃

@edx-pipeline-bot

edx-pipeline-bot commented Nov 7, 2017

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Wednesday, November 08, 2017.

@edx-pipeline-bot

edx-pipeline-bot commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@efischer19

efischer19 commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

This PR is causing production issues, see https://openedx.atlassian.net/browse/EDUCATOR-1724. The problem is that this setting to disable course creation has also inadvertently blocked library GETs.

I've created https://github.com/edx/edx-platform/pull/16522 to possibly address the issue; we need to either push that out or revert this PR before the weekend.

@efischer19 efischer19 mentioned this pull request Nov 9, 2017
Merged
efischer19 pushed a commit that referenced this pull request Nov 9, 2017
Eric Fischer
Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…
7696727 
…utton"

This reverts commit 9a9ef19, reversing
changes made to f61cbe7.
efischer19 pushed a commit that referenced this pull request Nov 9, 2017
Eric Fischer
Merge pull request #16524 from edx/efischer/revert_library
801a948 
Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…
efischer19 pushed a commit that referenced this pull request Nov 9, 2017
Eric Fischer
Merge pull request #16524 from edx/efischer/revert_library
c156eb2 
Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…
feanil pushed a commit that referenced this pull request Nov 9, 2017
Eric Fischer @feanil
Revert "Merge pull request #16447 from appsembler/omar/hide-library-b…
25b0898 
…utton"

This reverts commit 9a9ef19, reversing
changes made to f61cbe7.
@OmarIthawi

OmarIthawi commented Nov 11, 2017

Copy link
Copy Markdown
Member Author

Sorry about the production errors @efischer19. Looks like you've already went with the revert 👍. But if you'd like to bring this back again I'm happy to help!

efischer19 pushed a commit that referenced this pull request Nov 30, 2017
Eric Fischer
Revert "Revert "Merge pull request #16447 from appsembler/omar/hide-l…
f2f7b92 
…ibrary-button""

This reverts commit 7696727.
efischer19 pushed a commit that referenced this pull request Dec 4, 2017
Eric Fischer
Revert "Revert "Merge pull request #16447 from appsembler/omar/hide-l…
cb463c0 
…ibrary-button""

This reverts commit 7696727.
stvstnfrd pushed a commit to stvstnfrd/edx-platform that referenced this pull request Dec 7, 2018
Eric Fischer @stvstnfrd
Revert "Merge pull request openedx#16447 from appsembler/omar/hide-li…
91e2758 
…brary-button"

This reverts commit 9a9ef19, reversing
changes made to f61cbe7.
stvstnfrd pushed a commit to stvstnfrd/edx-platform that referenced this pull request Dec 7, 2018
Eric Fischer @stvstnfrd
Revert "Revert "Merge pull request openedx#16447 from appsembler/omar…
35a3db6 
…/hide-library-button""

This reverts commit 7696727.
This was referenced Dec 7, 2018
Closed
Merged
stvstnfrd added a commit to Stanford-Online/edx-platform that referenced this pull request Dec 10, 2018
@stvstnfrd
Merge pull request #849
b66ee76 
* stv/fix/library:
  Move library creator checks to POST-only
  Revert "Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button""
  Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button"
  Hide the create library for non-staff users when DISABLE_COURSE_CREATION
stanford-online-robot added a commit to Stanford-Online/edx-platform that referenced this pull request Dec 10, 2018
@stanford-online-robot
Nominate release candidate
202d651 
* origin/master:
  Add timestamp to Get Student Responses Report.
  Move library creator checks to POST-only
  Revert "Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button""
  Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button"
  Hide the create library for non-staff users when DISABLE_COURSE_CREATION
stanford-online-robot added a commit to Stanford-Online/edx-platform that referenced this pull request Dec 12, 2018
@stanford-online-robot
Release to production
cc6fd41 
* origin/rc: (1175 commits)
  Update Free Text Response to v0.3.1
  Add timestamp to Get Student Responses Report.
  Move library creator checks to POST-only
  Revert "Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button""
  Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button"
  Hide the create library for non-staff users when DISABLE_COURSE_CREATION
  Fix inline analytics close button styling.
  Fix eslint errors in account settings js
  Push version of Free Text Response to v0.3.0
  Fix errors with enrollment api.
  Revive account settings fork for uneditable fields
  Check the correct setting to hide login button
  Repatriate test that was erroneously deleted.
  Efficiency improvement for EnrollmentRosterView and helper method.
  Remove spaces for pep8
  Fix syntax error with enrollment filter
  Fix problems with grade reports after removing anonymous|lti
  Remove fake users from Insructor Dash enrollment count.
  Exclude unauthenticated and lti users from the grade reports.
  Add course start date for email context lost in Ficus merge
  Add course start date for email context lost in Ficus merge
  Add missing keywords to validator lost from Ficus merge
  Remove HTML template version of the GradeMe Button
  Update JS translation strings for Ginkgo
  Update translation config for consolidated tos and honor
  Install Stanford ORA2 from master, v1.4.7
  Fix keyword sub to work with new course updates
  Try fix circle
  Unfork grade report
  Cleanup LMS skip decorator
  Pin eslint-config-edx-es5 to older, version
  Bump edx-proctoring to 0.19.1
  Bump ux-pattern-library
  Bump Stanford XBlocks w/ lazy translation
  Bump Peer Instruction XBlock to edX version
  updated correct map when new score is calculated
  Fixed score update on rescore
  EDUCATOR-165 instructor task and UI for overriding learner grades.
  Reroute help link to FAQ marketing link
  Add setting to support ORA2 default django storage
  Remove edx text from Facebook sharing
  Unfork course-about-sidebar to add back facebook
  Force hint notification to take up entire width.
  Stop hard-coding @edxonline twitter username
  Float staff buttons to stop them from disappearing
  Restore "rescore only if score improves" messaging
  Toggle donate/blog footer links
  Remove course about sidebar optional include
  Add sneakpeek tos bar to bottom of course nav
  Center all login/register forms
  Move sneakpeek SASS to separate file
  Fix bulk captions utility
  Add more multi-processor testing
  Unfork privacy policy on registration
  Monkey-patch global footer text and links
  Remove Stanford Research disclaimer from dashboard
  Hide extraneous links from navbar
  Restore Stanford's SOA text in account settings
  Fix progress page
  Use unicode strings in LTI test
  Synchronize query counts
  Import ugettext lazily
  Restore Stanford's age restriction
  Fix python imports post-merge
  Restore Stanford changes to course tile listing
  Reintroduce Stanford navigation changes
  Add Stanford settings for devstack_docker
  Consolidate enrollment_api code
  Remove LTI tests that build on top of flaky permission alert tests.
  Remove flaky lti scenario.
  Upgrade setuptools to avoid bug while installing of OpenStack requirements RE: pypa/setuptools#951
  Fix safe_lxml.  SEC-338
  Force early installs of Django and nltk to avoid pip confusion
  GMT -> UTC in test
  Pin Jasmine version to avoid failing js tests
  A new favicon for Open edX
  Fix i18n for the page title in course tabs
  Pin moment dependency
  Use django storage mechanism to determine file size
  Adds THIRD_PARTY_AUTH_HINT to SiteConfiguration and to site-wide setting.FEATURES
  Allow i18n strings to be scraped from openedx/features
  Host poisoning vulnerability fix
  Strip `c` from `.pyc` for error message comparison
  Dont fetch caption on getting translations This fixes the endless loop of fetchCaptions ajax requests. fetchCaption on error calls fetchAvailableTranslations which again calls fetchCaption on success and so on. We don't see any significance for calling fetchCaption in fetchAvailableTranslations.
  Respect `BATCH_ENROLLMENT_NOTIFY_USERS_DEFAULT` setting for subsequent batches
  Move the user_attribute creation for site from within the user creation transaction to outside learner-1521
  EDUCATOR-1029 | More defensive version of ZeroSubsectionGrade.problem_scores
  EDUCATOR-915: force subsection grades to update when course grade updates
  Collect translation strings from the openedx folder
  Upgrade xblock-lti-consumer
  upgrade jenkins node version to 6.11.1
  Use ORA2 django storage on openstack and devstack.
  Add course import REST API to Studio
  Don't allow any user to create courses by default
  Set the MEDIA_ROOT and MEDIA_URL settings in the cms.envs.aws module
  Switch to forks of certain third-party repos
  Fix styling on non-Bootstrap pages
  Add Ginkgo translation resources on Transifex
  Set the RELEASE_LINE to ginkgo
  Updated Django Waffle to 0.12.0
  ...
stvstnfrd added a commit to stvstnfrd/edx-platform that referenced this pull request Aug 16, 2019
@stvstnfrd
Backport master to hawthorn/wip
6fcdfa1 
* origin/master:
  Add missing import
  Handle out-of-memory exception on Sysadmin Courses
  Add optional includes for Studio
  Use custom search filter generator to show course tiles for discovery search
  Fix search filter generator to search over all courses instead of none if no course provided
  Push version of Submit & Compare xblock to 0.7.0
  Add an optional include to the bottom of the instructor dashboard
  Fixed drop down buttons on header of bulk settings page
  Bump version for xblocks (qualtrics and image-modal)
  Update enrollment email templates
  Revert "Fix error on moving component when qualtrics xblock present."
  Fix error on moving component when qualtrics xblock present.
  EDUCATOR-3930 fix video player speed adjustments
  EDUCATOR-3930 fix video player speed adjustments
  Push Free Text Response xblock to v0.4.0
  Free Text Xblock needs v1.1.1 of xblock-utils
  Install version 0.1.7 of invideoquix xblock
  Update version of Platform Tour xBlock to v1.0.3
  Update version of Platform Tour xBlock to v1.0.3
  Update version of Platform Tour to 1.0.2
  Define egg version for Platform Tour xblock
  Centre X for inline-analytics.
  Update Platform Tour xBlock to v1.0.1
  Add Platform Tour xBlock to requirements
  Move CONTENT_VISIBILITY_NOTICE to theme
  Remove useless comment fork
  Revert "Split Studio Home page"
  Update Free Text Response to v0.3.1
  Update Free Text Response to v0.3.1
  Add timestamp to Get Student Responses Report.
  Move library creator checks to POST-only
  Revert "Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button""
  Revert "Merge pull request openedx#16447 from appsembler/omar/hide-library-button"
  Hide the create library for non-staff users when DISABLE_COURSE_CREATION
  Fix inline analytics close button styling.
  Fix eslint errors in account settings js
  Push version of Free Text Response to v0.3.0
  Fix errors with enrollment api.
  Revive account settings fork for uneditable fields
  Check the correct setting to hide login button
  Repatriate test that was erroneously deleted.
  Efficiency improvement for EnrollmentRosterView and helper method.
  Remove spaces for pep8
  Fix syntax error with enrollment filter
  Fix problems with grade reports after removing anonymous|lti
  Remove fake users from Insructor Dash enrollment count.
  Exclude unauthenticated and lti users from the grade reports.
  Add course start date for email context lost in Ficus merge
  Add course start date for email context lost in Ficus merge
  Add missing keywords to validator lost from Ficus merge
  Consolidate enrollment_api code
@OmarIthawi
OmarIthawi deleted the omar/hide-library-button branch November 21, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nasthagiri nasthagiri nasthagiri approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting prioritization open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OmarIthawi @openedx-webhooks @nedbat @edx-pipeline-bot @efischer19 @nasthagiri