Fix typo and an unclear description. - #126
Merged
Merged
Conversation
There was a problem hiding this comment.
would be nice to fix line length. The url name is actually just problemname, though perhaps the code also accepts problem/problemname.
Contributor
Author
|
@shnayder , I removed the extra text to make it clearer and I shortened the line length. Another look? |
|
As long as you confirmed in the code that the urlname is in fact the right thing to put there, 👍 |
Contributor
Author
|
Both work variations work, but I think just leaving it as urlname is a little bit easier and clearer. |
dianakhuang
added a commit
that referenced
this pull request
Jun 11, 2013
Fix typo and an unclear description.
chrisrossi
referenced
this pull request
in jazkarta/edx-platform
Mar 31, 2014
Victor/progress tracking
aboudreault
pushed a commit
to aboudreault/edx-platform
that referenced
this pull request
Jul 16, 2014
…t-id-to-workgroup-submissions added content_id to workgroup review submissions
doctoryes
pushed a commit
that referenced
this pull request
May 1, 2017
Bogus author addition for testing.
clemente
pushed a commit
to edx-olive-oc/edx-platform
that referenced
this pull request
May 1, 2018
…ix-for-unicode-course-files Fix Unicode course import. (Enabled python code lib import with GIT_IMPORT_STATIC set to False)
idegtiarov
pushed a commit
to Code-Institute-Org/edx-platform
that referenced
this pull request
Sep 17, 2018
…uth_user_add Fix "admin/auth/user/add "username" missing field.
xavierchan
added a commit
to xavierchan/edx-platform-1
that referenced
this pull request
Dec 20, 2018
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
- Place them only on the Outline page - Support a few cases where enrollment isn't actually allowed
ktyagiapphelix2u
pushed a commit
to ktyagiapphelix2u/edx-platform
that referenced
this pull request
Jun 2, 2025
…uirements-1cd0fd8 chore: Upgrade Python requirements
kiram15
pushed a commit
that referenced
this pull request
Feb 25, 2026
fix: null check for sso_provider_id in in enterprise_support/api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During bug triage, I found a couple of issues that could be fixed via simple text changes.
@sarina, @shnayder - it would be great if you could do the review to verify that these fixes do make things less confusing and are helpful.