Skip to content

Valera/no autoplay videoalpha studio - #123

Merged
valera-rozuvan merged 4 commits into
masterfrom
valera/no_autoplay_videoalpha_studio
Jun 14, 2013
Merged

Valera/no autoplay videoalpha studio#123
valera-rozuvan merged 4 commits into
masterfrom
valera/no_autoplay_videoalpha_studio

Conversation

@valera-rozuvan

Copy link
Copy Markdown
Contributor

Added autoplay attribute to videoalpha. Now in Studio the videos will not autoplay when Video Alpha advanced component will be used. In LMS the Video Alpha will auto play.

This functionality, along with the tests, was copied over from the original Video, and modified according to the new Xmodule.

@rocha please review.

@ghost ghost assigned Lyla-Fischer and rocha Jun 11, 2013
Comment thread lms/templates/videoalpha.html Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very likely that we won't be letting templates access settings anymore. Can you move the value outside the template? Also, if possible can you make sure it does not throw an exception if the setting is not defined:

settings.MITX_FEATURES.get('AUTOPLAY_VIDEOS', True)

@rocha

rocha commented Jun 12, 2013

Copy link
Copy Markdown
Contributor

Thanks for the changes.

LGTM 👍

Valera Rozuvan and others added 4 commits June 14, 2013 11:12
valera-rozuvan added a commit that referenced this pull request Jun 14, 2013
@valera-rozuvan
valera-rozuvan merged commit 2568a9b into master Jun 14, 2013
@valera-rozuvan
valera-rozuvan deleted the valera/no_autoplay_videoalpha_studio branch June 14, 2013 08:31
chrisrossi referenced this pull request in jazkarta/edx-platform Mar 31, 2014
Update jQuery and jQuery-UI to latest version
aboudreault pushed a commit to aboudreault/edx-platform that referenced this pull request Jul 16, 2014
…end-date-users-courses-list

added course start and end date
doctoryes pushed a commit that referenced this pull request Apr 25, 2017
Squirrel18 referenced this pull request in eduNEXT/edx-platform Jun 22, 2018
This solves the same problem as #123 for Docker Sync. Docker doesn't support using a volume for a directory, and excluding certain subdirectories. Users will need to sync the entire directory, and re-install Node dependencies, until we find a more appropriate solution.
idegtiarov pushed a commit to Code-Institute-Org/edx-platform that referenced this pull request Sep 17, 2018
…om-certificate-fields

Revert "Add certificate fields"
xavierchan pushed a commit to xavierchan/edx-platform-1 that referenced this pull request Dec 20, 2018
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
It got accidentally disabled during a refactor.

Also, try a little harder to make sure it doesn't re-appear during
the same browsing session.
ktyagiapphelix2u pushed a commit to ktyagiapphelix2u/edx-platform that referenced this pull request Jun 2, 2025
…uirements-00e5a8f

chore: Upgrade Python requirements
Danyal-Faheem pushed a commit to Danyal-Faheem/edx-platform that referenced this pull request Jul 15, 2025
Co-authored-by: AliSalman <alisalman@A006-00525.local>
kiram15 pushed a commit that referenced this pull request Feb 25, 2026
…ated-auth-n-mfe-redirection-for-enterprise-b-2-b-users

Revert "fix: fixed the redirection logic"
AhtishamShahid pushed a commit that referenced this pull request Mar 4, 2026
* Enable Forum Notifications for Threads#123
Preview

* chore: add edly custom comment

* fix: apply safe filter to comment body in email notification template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants