Put XBlock css and javascript onto the LMS courseware page - #1221
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Why did this used to cache its rendering? Seems silly: it will only be accessed once.
Contributor
Author
There was a problem hiding this comment.
Yeah, it was silly (at least in my mind).
Contributor
|
👍 |
Contributor
|
👍 aside from (a) failing tests (although this does appear to be a build issue) (b) a few comments. |
This required changing structural XModules to fully implement student_view, rather than just returning the HTML of their children in a get_html call. [LMS-223] [LMS-1170]
cpennington
added a commit
that referenced
this pull request
Oct 9, 2013
Put XBlock css and javascript onto the LMS courseware page
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Nov 30, 2018
…egration (openedx#1221) * api-integration version bump * api-integration version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required changing structural XModules to fully implement
student_view, rather than just returning the HTML of their children in a
get_html call.
[LMS-223]