Proxy to XModule on demand - #1088
Conversation
|
Seeing some legit failures/errors in the acceptance tests for this in both LMS and CMS. I didn't dig too deep, but it looks like most of the LMS errors are ValueError exceptions: "Got unexpected field names: ['user_id']" |
|
Ready for review! |
There was a problem hiding this comment.
COMMENTARY:
These tests updated due_date, which is no longer allowed in the LMS
There was a problem hiding this comment.
Where did the try/except go?
There was a problem hiding this comment.
Into the _xmodule property of XModuleDescriptor. We're lazily creating the XModule when it's needed, rather than on load.
|
Once you've responsibly handled the comments, 👍 |
|
@cpennington I agree with Ned - 👍 assuming you address all our comments. I don't currently have anything further to add. |
|
Looks like this needs a rebase. |
By transparently proxying between the XModuleDescriptor and the XModule, and between their runtimes, we can make them act as a single class, so that we can swap in an actual XBlock instead.
Previously, these tests modified due_date, which failed due to the new restrictions on writing to Scope.settings from the LMS.
…d-modules Proxy to XModule on demand
Merge pull request openedx#1054 from yokose-ks/develop/cypress/add-min-prope…
…ment-version [MCKIN-7315] SSO provider endpoint reworked
5 participants
@nedbat, @sarina: Ready for review.
This enables XModuleDescriptors to act like they're they're XBlocks that
have both studio_view and student_view.