Improvements in forums nav sidebar - #1169
Conversation
There was a problem hiding this comment.
can you conditionally run this if there is no focus? because this is saying always refocus the last thread, but isnt' there a case where the user is on the second from last thread for example, and then loads more, and those threads append to the end? in this case, don't you want to not change the focus?
There was a problem hiding this comment.
This is focusing the first thread that follows what was previously the last thread. It's not possible for the user to be focused on the second-to-last thread, because interacting with the "Load more" link moves focus there. One could argue that you don't want to move focus when you do something like click a sort button, but I think that always moving focus is the right thing to do.
There was a problem hiding this comment.
oh right right. not to split hairs, and i'm fine with ignore this, but you can tab to the load more while keeping another thread focused and click the load more link with a screen reader. i think it's acceptable behavior to use your algorithm however.
|
👍 works for me. had to make a bunch of posts but the improvements to focus on new posts made it super quick :) |
Now, when the list is reset (e.g. by sorting), the first thread is focused. When the "Load more" link is clicked, upon loading more threads, focus moves to the thread immediately following the thread that was previously last in the list.
|
👍 |
Improvements in forums nav sidebar
…3_connection_for_ga_operation Fix cannot get S3 connection for ga_operation openedx#1167
api-integration version bump
3 participants
@kevinchugh @marcotuts
Caveat: Apparently, when you click "Load more", the newly loaded threads are not always appended to the end of the list. The focus simply goes to whatever thread is after the thread that was previously the last one in the list. If all of the newly loaded threads are inserted higher in the list, then focus will be lost.