Skip to content

Fix/kevin/forums accessibility - #1167

Merged
gwprice merged 2 commits into
rc/2013-09-30from
fix/kevin/forums_accessibility
Sep 27, 2013
Merged

Fix/kevin/forums accessibility#1167
gwprice merged 2 commits into
rc/2013-09-30from
fix/kevin/forums_accessibility

Conversation

@kevinchugh

Copy link
Copy Markdown
Contributor

This update modifies the vote elements dynamically for both when the forums are loaded and when the user toggles his or her votes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/click vote/click to vote/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

@kevinchugh

Copy link
Copy Markdown
Contributor Author

@gwprice @jimabramson i think i got it this time.

@marcotuts

Copy link
Copy Markdown
Contributor

This worked for me with the exception of inline posts. I can still vote and unvote on ChromeVox but it isn't as nice as it was i nthe main discussion forum, where it read the vote count and told me what I could do next.

@gwprice

gwprice commented Sep 27, 2013

Copy link
Copy Markdown

👍

@marcotuts

Copy link
Copy Markdown
Contributor

👍 works for inline and main forums

@gwprice
gwprice merged commit c850be4 into rc/2013-09-30 Sep 27, 2013
@jzoldak
jzoldak deleted the fix/kevin/forums_accessibility branch May 5, 2014 14:56
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 16, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 16, 2016
…3_connection_for_ga_operation

Fix cannot get S3 connection for ga_operation openedx#1167
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
…ew_problem_for_dogwood_release

Fix few problem for dogwood release openedx#1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants