Skip to content

Bump ORA version to 0.2.7. #11429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cahrens merged 1 commit into from
Feb 5, 2016
Merged

Bump ORA version to 0.2.7. #11429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/edx/github.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ git+https://github.com/edx/XBlock.git@xblock-0.4.4#egg=XBlock==0.4.4
-e git+https://github.com/edx/event-tracking.git@0.2.1#egg=event-tracking==0.2.1
-e git+https://github.com/edx/django-splash.git@v0.2#egg=django-splash==0.2
-e git+https://github.com/edx/acid-block.git@e46f9cda8a03e121a00c7e347084d142d22ebfb7#egg=acid-xblock
-e git+https://github.com/edx/edx-ora2.git@0.2.6#egg=ora2==0.2.6
-e git+https://github.com/edx/edx-ora2.git@0.2.7#egg=ora2==0.2.7

@nedbat nedbat Feb 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now would be a fine time to remove the -e.

@cahrens cahrens Feb 4, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedbat
What does it mean to remove the "-e"? Why was it there before, and why do we no longer need it?

@nedbat nedbat Feb 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -e means, install as an editable working tree. We never needed it, it's been cargo-culted from the beginning. It's allowed us to have bugs in our setup.py files that we don't find until much later.

The instructions at the top of the file were an attempt to get people to stop using it. :)

@cahrens cahrens Feb 4, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedbat thanks. I would think you knew by now that nobody reads the instructions at the top of the file (unless the thing they are changing is at the top of the file). :)

-e git+https://github.com/edx/edx-submissions.git@0.1.3#egg=edx-submissions==0.1.3
git+https://github.com/edx/ease.git@release-2015-07-14#egg=ease==0.1.3
git+https://github.com/edx/i18n-tools.git@v0.2#egg=i18n-tools==v0.2
Expand Down