Skip to content

Bump ORA version to 0.2.7. - #11429

Merged
cahrens merged 1 commit into
masterfrom
christina/ora-release
Feb 5, 2016
Merged

Bump ORA version to 0.2.7.#11429
cahrens merged 1 commit into
masterfrom
christina/ora-release

Conversation

@cahrens

@cahrens cahrens commented Feb 4, 2016

Copy link
Copy Markdown

No description provided.

Comment thread requirements/edx/github.txt Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now would be a fine time to remove the -e.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedbat
What does it mean to remove the "-e"? Why was it there before, and why do we no longer need it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -e means, install as an editable working tree. We never needed it, it's been cargo-culted from the beginning. It's allowed us to have bugs in our setup.py files that we don't find until much later.

The instructions at the top of the file were an attempt to get people to stop using it. :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedbat thanks. I would think you knew by now that nobody reads the instructions at the top of the file (unless the thing they are changing is at the top of the file). :)

@cahrens

cahrens commented Feb 4, 2016

Copy link
Copy Markdown
Author

jenkins run bokchoy

@cahrens
cahrens force-pushed the christina/ora-release branch from dc8152b to 0a900cf Compare February 4, 2016 22:28
@nedbat

nedbat commented Feb 4, 2016

Copy link
Copy Markdown
Contributor

The test failures are because of the errors in ora's setup.py: it doesn't name all of the packages that it should.

@cahrens

cahrens commented Feb 5, 2016

Copy link
Copy Markdown
Author

Thanks, @nedbat. So does ora2 need to declare EVERY package it has? Is there no concept of "private" packages?

For instance, there is an init file in openassessment/assessment/migrations, but it seems odd to declare that as a package.

See openedx/edx-ora2#865

@cahrens
cahrens force-pushed the christina/ora-release branch from b269cad to 0a900cf Compare February 5, 2016 13:06
@nedbat

nedbat commented Feb 5, 2016

Copy link
Copy Markdown
Contributor

If you want the code to be installed when the kit is installed, then it needs to be in the packages list. That's all that list is for: what packages are in the kit, and need to be copied during installation. Many people avoid an explicit list of packages by doing this:

from setuptools import find_packages
...
setup(
    ....
    packages=find_packages(),
    ...
)

Some people exclude certain packages, but there it isn't required.

@cahrens

cahrens commented Feb 5, 2016

Copy link
Copy Markdown
Author

jenkins run lettuce

@cahrens
cahrens force-pushed the christina/ora-release branch from 0a900cf to 4c93835 Compare February 5, 2016 14:31
@cahrens

cahrens commented Feb 5, 2016

Copy link
Copy Markdown
Author

jenkins run bokchoy

cahrens pushed a commit that referenced this pull request Feb 5, 2016
@cahrens
cahrens merged commit 481f322 into master Feb 5, 2016
@cahrens
cahrens deleted the christina/ora-release branch February 5, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants