Allow xblocks to clear state - #11371
Closed
efischer19 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
There was a problem hiding this comment.
This block was causing scary-looking 400 errors in testing sometimes, I figured that since the above comments say it's possible for a score to exist even if no student module exists., it's okay to just log the lookup failure and continue here.
Contributor
Author
|
Note to reviewers: The automated jenkins tests (save some of the quality test, that's on me) are failing because jenkins doesn't know about the In either case, the failures are not unexpected and can be easily resolved. |
efischer19
force-pushed
the
efischer/delete_student_state
branch
from
February 1, 2016 17:33
63e7f2f to
8a19317
Compare
efischer19
force-pushed
the
efischer/delete_student_state
branch
3 times, most recently
from
February 3, 2016 14:54
16f0dc5 to
6fe1d79
Compare
My original task was to fix clear state specifically for ORA2 problems. As I dug in, I noticed that the reset_student_attempts code was aware of edx-submissions, but not openassessment. Rather than adding another IDA for edx-platform to concern itself with, I elected to make a way for *any* xblock to clear its state as a part of this method, as that seems like a general problem. As a nice side bonus, this edx-platform code no longer needs to know about anything in edx-submissions, as openassessment will pass through to get any submissions data removed as part of its clear method.
efischer19
force-pushed
the
efischer/delete_student_state
branch
from
February 3, 2016 21:12
6fe1d79 to
de7fa90
Compare
efischer19
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My original task was to fix clear state specifically for ORA2 problems.
As I dug in, I noticed that the reset_student_attempts code was aware
of edx-submissions, but not openassessment.
Rather than adding another IDA for edx-platform to concern itself with,
I elected to make a way for any xblock to clear its state as a part
of this method, as that seems like a general problem.
As a nice side bonus, this edx-platform code no longer needs to know
about anything in edx-submissions, as openassessment will pass through
to get any submissions data removed as part of its clear method.
Sibling change to openedx/edx-ora2#862 and openedx/edx-submissions#33