Delete Student State ORA fix (Proof-of-concept) - #32
Closed
efischer19 wants to merge 1 commit into
Closed
Conversation
Not at all the final version of this, but I have tested this locally, and it deletes what we need to delete and seems to solve all the problems described in TNL-3880.
efischer19
force-pushed
the
efischer/delete_studentitem
branch
from
January 28, 2016 21:46
dcad7a6 to
7440723
Compare
Contributor
Author
There was a problem hiding this comment.
Note to reviewers: the default behavior in django is to cascade on delete (https://docs.djangoproject.com/en/1.8/ref/models/fields/, ctrl-F on_delete). Because of this behavior, this single lookup-then-delete will obliterate any trace of this item/student/user triplet in the submissions database.
One thing to investigate - how will this affect data in the assessment and workflow databases? Those entries are almost always keyed on submission['uuid'], so I'd imagine they'll just be orphaned, and possibly still included in a data dump? I'll keep digging there.
efischer19
force-pushed
the
efischer/delete_studentitem
branch
from
January 29, 2016 19:37
964f34d to
7440723
Compare
Contributor
Author
|
Closing in favor of #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not at all the final version of this, but I have tested this locally,
and it deletes what we need to delete and seems to solve all the problems
described in TNL-3880.
Pairs with https://github.com/edx/edx-platform/pull/11371