Feature/christina/metadata ui - #11
Conversation
… well as examples for dropdown case and extra logic required there
…ostly to view component.html
…l as is-set mode styling. no js behavior in yet. adds overscoll fix for webkit
…ms, fonts, colors, etc; currently open select box issue on chrome
…, etc standards. also opted to try out initial pass at hierarchy splitting of css classes on items that repeat (li, for example)
…nto feature/christina/metadata-ui
|
@cahrens 👍 |
Good to go. Bug that i found, is not reproducible, do not mind. |
There was a problem hiding this comment.
Why not move this into defaults too?
There was a problem hiding this comment.
max_grade isn't being exposed in the UI. I didn't try to move settings that I wasn't touching. I'll let you do that. :)
…x/edx-platform into feature/christina/metadata-ui
…atform into feature/christina/metadata-ui
|
Note somewhat for myself (to remember on Monday). Ran all the CMS acceptance tests and they passed. |
There was a problem hiding this comment.
Looks like this is rendering the template, which really belongs in the render method. Also, why is it appending to this.$el, instead of replacing its HTML?
There was a problem hiding this comment.
I changed it to set the HTML. I didn't put this in the render method because the template itself doesn't need to re-render each time. But perhaps that it is too much of an optimization? We can chat on Monday at the lunch-and-learn, and I can always change it later.
|
Just nitpicks from me -- nothing that would block this from being merged. Go for it. |
* remotes/tosin/tandc: [#118162721] set t and c URL to point to '/legal'
…icked Implement edx.ui.lms.link_clicked transformer with currently available data attributes.
Adds the Studio version of the compiled static JS translation files
Change notification API response format Approved-by: Oksana Slusarenko
* feat: add bookmarking for units * refactor: add redux for state management
I am ready for folks to start code reviewing my pull request. Since there are 69 files in the pull request, I have split them up into categories. Please look for the category or categories with your name. Please review by Friday of this week (or let me know if you cannot do the review).
To try out the feature, pull the branch and try creating/editing components (on the unit page) in Studio. There should be a "Settings" view to the components, where you can edit the metadata.
If you have any questions, let me know and we can go over the changes together.
Thanks!
Christina
Lettuce integration tests (Jay, DB if interested)
Jasmine unit tests (Jay, DB)
New JavaScript/HTML (DB, Don) and updates to metadata fields
CSS (Brian)
Cleanup of templates (Don)
See also yaml files listed below (openended, peer grading, word cloud)
Openended and peer grading (Vik)
Wordcloud (Alex)