This repository was archived by the owner on Nov 12, 2023. It is now read-only.
SE-1155 Allows unicode usernames to be used in CCX enrollments and reports. - #11
Merged
samuelallan72 merged 2 commits intoAug 7, 2019
Conversation
Previously, unicode would result in a UnicodeEncodeError as a result of the format string being str instead of unicode. Additionally, the log calls would crash with a traceback (while not affecting the program flow). (cherry picked from commit 54f9434)
pomegranited
approved these changes
Aug 7, 2019
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
👍
- I tested this on my campus devstack using the instructions from https://github.com/edx/edx-platform/pull/21248
- I checked the code against the original PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, unicode would result in a UnicodeEncodeError as a result of
the format string being str instead of unicode.
Additionally, the log calls would crash with a traceback (while not
affecting the program flow).
(cherry picked from commit 54f9434)
Sandbox:
Testing:
See https://github.com/edx/edx-platform/pull/21248
Settings