Skip to content

More-correct data migrations #10590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedbat merged 1 commit into from
Nov 11, 2015
Merged

More-correct data migrations #10590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions common/djangoapps/dark_lang/migrations/0002_data__enable_on_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ def create_dark_lang_config(apps, schema_editor):
Enable DarkLang by default when it is installed, to prevent accidental
release of testing languages.
"""
dark_lang_model = apps.get_model("dark_lang", "DarkLangConfig")
DarkLangConfig = apps.get_model("dark_lang", "DarkLangConfig")
db_alias = schema_editor.connection.alias

if not dark_lang_model.objects.using(db_alias).exists():
dark_lang_model.objects.using(db_alias).create(enabled=True)
objects = DarkLangConfig.objects.using(db_alias)
if not objects.exists():
objects.create(enabled=True)

def remove_dark_lang_config(apps, schema_editor):
"""Write your backwards methods here."""
Expand Down
7 changes: 5 additions & 2 deletions common/djangoapps/util/migrations/0002_data__default_rate_limit_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@

def forwards(apps, schema_editor):
"""Ensure that rate limiting is enabled by default. """
rate_limit_configuration_model = apps.get_model("util", "RateLimitConfiguration")
RateLimitConfiguration = apps.get_model("util", "RateLimitConfiguration")
db_alias = schema_editor.connection.alias
rate_limit_configuration_model.objects.using(db_alias).get_or_create(enabled=True)
objects = RateLimitConfiguration.objects.using(db_alias)
if not objects.exists():
objects.create(enabled=True)


class Migration(migrations.Migration):

Expand Down
10 changes: 6 additions & 4 deletions lms/djangoapps/certificates/migrations/0003_data__default_modes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@

def forwards(apps, schema_editor):
"""Add default modes"""
badge_image_configuration_model = apps.get_model("certificates", "BadgeImageConfiguration")
BadgeImageConfiguration = apps.get_model("certificates", "BadgeImageConfiguration")
db_alias = schema_editor.connection.alias

for mode in ['honor', 'verified', 'professional']:
conf, created = badge_image_configuration_model.objects.get_or_create(mode=mode)
if created:
objects = BadgeImageConfiguration.objects.using(db_alias)
if not objects.exists():
for mode in ['honor', 'verified', 'professional']:
conf = objects.create(mode=mode)
file_name = '{0}{1}'.format(mode, '.png')
conf.icon.save(
'badges/{}'.format(file_name),
Expand Down